Re: [PATCH v3 33/41] target/openrisc: Make openrisc_cpu_tlb_fill sysemu only

[Philippe Mathieu-Daudé]

On 10/1/21 19:11, Richard Henderson wrote:
> The fallback code in raise_sigsegv is sufficient for openrisc.
> This makes all of the code in mmu.c sysemu only, so remove
> the ifdefs and move the file to openrisc_softmmu_ss.
> Remove the code from cpu_loop that handled EXCP_DPF.
> 
> Cc: Stafford Horne <shorne@gmail.com>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/openrisc/cpu.h          | 7 ++++---
>  linux-user/openrisc/cpu_loop.c | 8 --------
>  target/openrisc/cpu.c          | 2 +-
>  target/openrisc/mmu.c          | 8 --------
>  target/openrisc/meson.build    | 2 +-
>  5 files changed, 6 insertions(+), 21 deletions(-)

>  static void raise_mmu_exception(OpenRISCCPU *cpu, target_ulong address,
>                                  int exception)
> @@ -113,7 +109,6 @@ bool openrisc_cpu_tlb_fill(CPUState *cs, vaddr addr, int 
> size,
>      OpenRISCCPU *cpu = OPENRISC_CPU(cs);
>      int excp = EXCP_DPF;
>  

^ Can we remove this extra line? Otherwise:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> -#ifndef CONFIG_USER_ONLY
>      int prot;
>      hwaddr phys_addr;
>  
> @@ -138,13 +133,11 @@ bool openrisc_cpu_tlb_fill(CPUState *cs, vaddr addr, 
> int size,
>      if (probe) {
>          return false;
>      }
> -#endif