Re: [PATCH 6/8] target/mips: Use explicit extract32() calls in gen_msa

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 6/8] target/mips: Use explicit extract32() calls in gen_msa_i

From:	Richard Henderson
Subject:	Re: [PATCH 6/8] target/mips: Use explicit extract32() calls in gen_msa_i5()
Date:	Sun, 3 Oct 2021 15:35:18 -0400
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 10/3/21 1:57 PM, Philippe Mathieu-Daudé wrote:

We already use sextract32(), use extract32() for completeness
instead of open-coding it.

Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
---
  target/mips/tcg/msa_translate.c | 11 ++++-------
  1 file changed, 4 insertions(+), 7 deletions(-)


Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 1/8] target/mips: Remove unused register from MSA 2R/2RF instruction format, (continued)
- [PATCH 1/8] target/mips: Remove unused register from MSA 2R/2RF instruction format, Philippe Mathieu-Daudé, 2021/10/03
- [PATCH 2/8] target/mips: Use tcg_constant_i32() in gen_msa_elm_df(), Philippe Mathieu-Daudé, 2021/10/03
  - Re: [PATCH 2/8] target/mips: Use tcg_constant_i32() in gen_msa_elm_df(), Richard Henderson, 2021/10/03
- [PATCH 3/8] target/mips: Use tcg_constant_i32() in gen_msa_2rf(), Philippe Mathieu-Daudé, 2021/10/03
  - Re: [PATCH 3/8] target/mips: Use tcg_constant_i32() in gen_msa_2rf(), Richard Henderson, 2021/10/03
- [PATCH 4/8] target/mips: Use tcg_constant_i32() in gen_msa_2r(), Philippe Mathieu-Daudé, 2021/10/03
  - Re: [PATCH 4/8] target/mips: Use tcg_constant_i32() in gen_msa_2r(), Richard Henderson, 2021/10/03
- [PATCH 5/8] target/mips: Use tcg_constant_i32() in gen_msa_3rf(), Philippe Mathieu-Daudé, 2021/10/03
  - Re: [PATCH 5/8] target/mips: Use tcg_constant_i32() in gen_msa_3rf(), Richard Henderson, 2021/10/03
- [PATCH 6/8] target/mips: Use explicit extract32() calls in gen_msa_i5(), Philippe Mathieu-Daudé, 2021/10/03
  - Re: [PATCH 6/8] target/mips: Use explicit extract32() calls in gen_msa_i5(), Richard Henderson <=
- [PATCH 7/8] target/mips: Use tcg_constant_i32() in gen_msa_i5(), Philippe Mathieu-Daudé, 2021/10/03
  - Re: [PATCH 7/8] target/mips: Use tcg_constant_i32() in gen_msa_i5(), Richard Henderson, 2021/10/03
- [PATCH 8/8] target/mips: Use tcg_constant_tl() in gen_compute_compact_branch(), Philippe Mathieu-Daudé, 2021/10/03
  - Re: [PATCH 8/8] target/mips: Use tcg_constant_tl() in gen_compute_compact_branch(), Richard Henderson, 2021/10/03
- Re: [PATCH 0/8] target/mips: Use tcg_constant_*, Philippe Mathieu-Daudé, 2021/10/11

Prev by Date: Re: [PATCH 5/8] target/mips: Use tcg_constant_i32() in gen_msa_3rf()
Next by Date: Re: [PATCH 7/8] target/mips: Use tcg_constant_i32() in gen_msa_i5()
Previous by thread: [PATCH 6/8] target/mips: Use explicit extract32() calls in gen_msa_i5()
Next by thread: [PATCH 7/8] target/mips: Use tcg_constant_i32() in gen_msa_i5()
Index(es):
- Date
- Thread