[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/12] macfb: fix invalid object reference in macfb_common_re
From: |
Laurent Vivier |
Subject: |
Re: [PATCH 02/12] macfb: fix invalid object reference in macfb_common_realize() |
Date: |
Mon, 4 Oct 2021 10:49:21 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
Le 02/10/2021 à 12:59, Mark Cave-Ayland a écrit :
> During realize memory_region_init_ram_nomigrate() is used to initialise the
> RAM
> memory region used for the framebuffer but the owner object reference is
> incorrect since MacFbState is a typedef and not a QOM type.
>
> Change the memory region owner to be the corresponding DeviceState to fix the
> issue and prevent random crashes during macfb_common_realize().
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
> hw/display/macfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/display/macfb.c b/hw/display/macfb.c
> index 2b747a8de8..815870f2fe 100644
> --- a/hw/display/macfb.c
> +++ b/hw/display/macfb.c
> @@ -365,7 +365,7 @@ static void macfb_common_realize(DeviceState *dev,
> MacfbState *s, Error **errp)
> memory_region_init_io(&s->mem_ctrl, OBJECT(dev), &macfb_ctrl_ops, s,
> "macfb-ctrl", 0x1000);
>
> - memory_region_init_ram_nomigrate(&s->mem_vram, OBJECT(s), "macfb-vram",
> + memory_region_init_ram_nomigrate(&s->mem_vram, OBJECT(dev), "macfb-vram",
> MACFB_VRAM_SIZE, errp);
> s->vram = memory_region_get_ram_ptr(&s->mem_vram);
> s->vram_bit_mask = MACFB_VRAM_SIZE - 1;
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
- [PATCH 00/12] macfb: fixes for booting MacOS, Mark Cave-Ayland, 2021/10/02
- [PATCH 01/12] macfb: handle errors that occur during realize, Mark Cave-Ayland, 2021/10/02
- [PATCH 02/12] macfb: fix invalid object reference in macfb_common_realize(), Mark Cave-Ayland, 2021/10/02
- [PATCH 04/12] macfb: use memory_region_init_ram() in macfb_common_realize() for the framebuffer, Mark Cave-Ayland, 2021/10/02
- [PATCH 03/12] macfb: fix overflow of color_palette array, Mark Cave-Ayland, 2021/10/02
- [PATCH 07/12] macfb: add qdev property to specify display type, Mark Cave-Ayland, 2021/10/02