qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 01/12] macfb: handle errors that occur during realize


From: Mark Cave-Ayland
Subject: Re: [PATCH 01/12] macfb: handle errors that occur during realize
Date: Mon, 4 Oct 2021 19:39:41 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0

On 02/10/2021 14:47, Philippe Mathieu-Daudé wrote:

On 10/2/21 12:59, Mark Cave-Ayland wrote:
Make sure any errors that occur within the macfb realize chain are detected
and handled correctly to prevent crashes and to ensure that error messages are
reported back to the user.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
  hw/display/macfb.c | 11 +++++++++++
  1 file changed, 11 insertions(+)

diff --git a/hw/display/macfb.c b/hw/display/macfb.c
index 76808b69cc..2b747a8de8 100644
--- a/hw/display/macfb.c
+++ b/hw/display/macfb.c
@@ -379,6 +379,10 @@ static void macfb_sysbus_realize(DeviceState *dev, Error 
**errp)
      MacfbState *ms = &s->macfb;
macfb_common_realize(dev, ms, errp);
+    if (*errp) {
+        return;
+    }

See a related discussion:
87bl47ll9l.fsf@dusky.pond.sub.org/">https://lore.kernel.org/qemu-devel/87bl47ll9l.fsf@dusky.pond.sub.org/

Interesting, thanks for the link. I will update macfb_common_realize() to return a boolean for v2.


ATB,

Mark.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]