[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH v2 05/25] assertions for block global state API
|
From: |
Emanuele Giuseppe Esposito |
|
Subject: |
[RFC PATCH v2 05/25] assertions for block global state API |
|
Date: |
Tue, 5 Oct 2021 10:31:55 -0400 |
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
---
block.c | 135 +++++++++++++++++++++++++++++++++++++++++++++++--
block/commit.c | 2 +
block/io.c | 20 ++++++++
blockdev.c | 1 +
4 files changed, 155 insertions(+), 3 deletions(-)
diff --git a/block.c b/block.c
index d31543ac37..6121af7040 100644
--- a/block.c
+++ b/block.c
@@ -384,6 +384,7 @@ char *bdrv_get_full_backing_filename(BlockDriverState *bs,
Error **errp)
void bdrv_register(BlockDriver *bdrv)
{
assert(bdrv->format_name);
+ g_assert(qemu_in_main_thread());
QLIST_INSERT_HEAD(&bdrv_drivers, bdrv, list);
}
@@ -392,6 +393,8 @@ BlockDriverState *bdrv_new(void)
BlockDriverState *bs;
int i;
+ g_assert(qemu_in_main_thread());
+
bs = g_new0(BlockDriverState, 1);
QLIST_INIT(&bs->dirty_bitmaps);
for (i = 0; i < BLOCK_OP_TYPE_MAX; i++) {
@@ -416,6 +419,7 @@ BlockDriverState *bdrv_new(void)
static BlockDriver *bdrv_do_find_format(const char *format_name)
{
BlockDriver *drv1;
+ g_assert(qemu_in_main_thread());
QLIST_FOREACH(drv1, &bdrv_drivers, list) {
if (!strcmp(drv1->format_name, format_name)) {
@@ -431,6 +435,8 @@ BlockDriver *bdrv_find_format(const char *format_name)
BlockDriver *drv1;
int i;
+ g_assert(qemu_in_main_thread());
+
drv1 = bdrv_do_find_format(format_name);
if (drv1) {
return drv1;
@@ -480,11 +486,13 @@ static int bdrv_format_is_whitelisted(const char
*format_name, bool read_only)
int bdrv_is_whitelisted(BlockDriver *drv, bool read_only)
{
+ g_assert(qemu_in_main_thread());
return bdrv_format_is_whitelisted(drv->format_name, read_only);
}
bool bdrv_uses_whitelist(void)
{
+ g_assert(qemu_in_main_thread());
return use_bdrv_whitelist;
}
@@ -515,6 +523,8 @@ int bdrv_create(BlockDriver *drv, const char* filename,
{
int ret;
+ g_assert(qemu_in_main_thread());
+
Coroutine *co;
CreateCo cco = {
.drv = drv,
@@ -690,6 +700,8 @@ int bdrv_create_file(const char *filename, QemuOpts *opts,
Error **errp)
QDict *qdict;
int ret;
+ g_assert(qemu_in_main_thread());
+
drv = bdrv_find_protocol(filename, true, errp);
if (drv == NULL) {
return -ENOENT;
@@ -787,6 +799,7 @@ int bdrv_probe_blocksizes(BlockDriverState *bs, BlockSizes
*bsz)
{
BlockDriver *drv = bs->drv;
BlockDriverState *filtered = bdrv_filter_bs(bs);
+ g_assert(qemu_in_main_thread());
if (drv && drv->bdrv_probe_blocksizes) {
return drv->bdrv_probe_blocksizes(bs, bsz);
@@ -807,6 +820,7 @@ int bdrv_probe_geometry(BlockDriverState *bs, HDGeometry
*geo)
{
BlockDriver *drv = bs->drv;
BlockDriverState *filtered = bdrv_filter_bs(bs);
+ g_assert(qemu_in_main_thread());
if (drv && drv->bdrv_probe_geometry) {
return drv->bdrv_probe_geometry(bs, geo);
@@ -861,6 +875,7 @@ static BlockDriver *find_hdev_driver(const char *filename)
{
int score_max = 0, score;
BlockDriver *drv = NULL, *d;
+ g_assert(qemu_in_main_thread());
QLIST_FOREACH(d, &bdrv_drivers, list) {
if (d->bdrv_probe_device) {
@@ -878,6 +893,7 @@ static BlockDriver *find_hdev_driver(const char *filename)
static BlockDriver *bdrv_do_find_protocol(const char *protocol)
{
BlockDriver *drv1;
+ g_assert(qemu_in_main_thread());
QLIST_FOREACH(drv1, &bdrv_drivers, list) {
if (drv1->protocol_name && !strcmp(drv1->protocol_name, protocol)) {
@@ -898,6 +914,7 @@ BlockDriver *bdrv_find_protocol(const char *filename,
const char *p;
int i;
+ g_assert(qemu_in_main_thread());
/* TODO Drivers without bdrv_file_open must be specified explicitly */
/*
@@ -963,6 +980,7 @@ BlockDriver *bdrv_probe_all(const uint8_t *buf, int
buf_size,
{
int score_max = 0, score;
BlockDriver *drv = NULL, *d;
+ g_assert(qemu_in_main_thread());
QLIST_FOREACH(d, &bdrv_drivers, list) {
if (d->bdrv_probe) {
@@ -1110,6 +1128,7 @@ int bdrv_parse_aio(const char *mode, int *flags)
*/
int bdrv_parse_discard_flags(const char *mode, int *flags)
{
+ g_assert(qemu_in_main_thread());
*flags &= ~BDRV_O_UNMAP;
if (!strcmp(mode, "off") || !strcmp(mode, "ignore")) {
@@ -1130,6 +1149,7 @@ int bdrv_parse_discard_flags(const char *mode, int *flags)
*/
int bdrv_parse_cache_mode(const char *mode, int *flags, bool *writethrough)
{
+ g_assert(qemu_in_main_thread());
*flags &= ~BDRV_O_CACHE_MASK;
if (!strcmp(mode, "off") || !strcmp(mode, "none")) {
@@ -1494,6 +1514,7 @@ static void bdrv_assign_node_name(BlockDriverState *bs,
Error **errp)
{
char *gen_node_name = NULL;
+ g_assert(qemu_in_main_thread());
if (!node_name) {
node_name = gen_node_name = id_generate(ID_BLOCK);
@@ -1608,6 +1629,8 @@ BlockDriverState *bdrv_new_open_driver(BlockDriver *drv,
const char *node_name,
BlockDriverState *bs;
int ret;
+ g_assert(qemu_in_main_thread());
+
bs = bdrv_new();
bs->open_flags = flags;
bs->explicit_options = qdict_new();
@@ -1720,6 +1743,7 @@ static int bdrv_open_common(BlockDriverState *bs,
BlockBackend *file,
assert(bs->file == NULL);
assert(options != NULL && bs->options != options);
+ g_assert(qemu_in_main_thread());
opts = qemu_opts_create(&bdrv_runtime_opts, NULL, 0, &error_abort);
if (!qemu_opts_absorb_qdict(opts, options, errp)) {
@@ -2977,6 +3001,8 @@ BdrvChild *bdrv_attach_child(BlockDriverState *parent_bs,
BdrvChild *child = NULL;
Transaction *tran = tran_new();
+ g_assert(qemu_in_main_thread());
+
ret = bdrv_attach_child_noperm(parent_bs, child_bs, child_name,
child_class,
child_role, &child, tran, errp);
if (ret < 0) {
@@ -3003,6 +3029,8 @@ void bdrv_root_unref_child(BdrvChild *child)
{
BlockDriverState *child_bs;
+ g_assert(qemu_in_main_thread());
+
child_bs = child->bs;
bdrv_detach_child(child);
bdrv_unref(child_bs);
@@ -3077,6 +3105,7 @@ static void bdrv_unset_inherits_from(BlockDriverState
*root, BdrvChild *child,
/* Callers must ensure that child->frozen is false. */
void bdrv_unref_child(BlockDriverState *parent, BdrvChild *child)
{
+ g_assert(qemu_in_main_thread());
if (child == NULL) {
return;
}
@@ -3227,6 +3256,8 @@ int bdrv_set_backing_hd(BlockDriverState *bs,
BlockDriverState *backing_hd,
int ret;
Transaction *tran = tran_new();
+ g_assert(qemu_in_main_thread());
+
ret = bdrv_set_backing_noperm(bs, backing_hd, tran, errp);
if (ret < 0) {
goto out;
@@ -3262,6 +3293,8 @@ int bdrv_open_backing_file(BlockDriverState *bs, QDict
*parent_options,
QDict *tmp_parent_options = NULL;
Error *local_err = NULL;
+ g_assert(qemu_in_main_thread());
+
if (bs->backing != NULL) {
goto free_exit;
}
@@ -3421,6 +3454,8 @@ BdrvChild *bdrv_open_child(const char *filename,
{
BlockDriverState *bs;
+ g_assert(qemu_in_main_thread());
+
bs = bdrv_open_child_bs(filename, options, bdref_key, parent, child_class,
child_role, allow_none, errp);
if (bs == NULL) {
@@ -3443,6 +3478,8 @@ BlockDriverState *bdrv_open_blockdev_ref(BlockdevRef
*ref, Error **errp)
const char *reference = NULL;
Visitor *v = NULL;
+ g_assert(qemu_in_main_thread());
+
if (ref->type == QTYPE_QSTRING) {
reference = ref->u.reference;
} else {
@@ -3840,6 +3877,8 @@ close_and_fail:
BlockDriverState *bdrv_open(const char *filename, const char *reference,
QDict *options, int flags, Error **errp)
{
+ g_assert(qemu_in_main_thread());
+
return bdrv_open_inherit(filename, reference, options, flags, NULL,
NULL, 0, errp);
}
@@ -4094,12 +4133,15 @@ BlockReopenQueue *bdrv_reopen_queue(BlockReopenQueue
*bs_queue,
BlockDriverState *bs,
QDict *options, bool keep_old_opts)
{
+ g_assert(qemu_in_main_thread());
+
return bdrv_reopen_queue_child(bs_queue, bs, options, NULL, 0, false,
NULL, 0, keep_old_opts);
}
void bdrv_reopen_queue_free(BlockReopenQueue *bs_queue)
{
+ g_assert(qemu_in_main_thread());
if (bs_queue) {
BlockReopenQueueEntry *bs_entry, *next;
QTAILQ_FOREACH_SAFE(bs_entry, bs_queue, entry, next) {
@@ -4247,6 +4289,8 @@ int bdrv_reopen(BlockDriverState *bs, QDict *opts, bool
keep_old_opts,
BlockReopenQueue *queue;
int ret;
+ g_assert(qemu_in_main_thread());
+
bdrv_subtree_drained_begin(bs);
if (ctx != qemu_get_aio_context()) {
aio_context_release(ctx);
@@ -4268,6 +4312,8 @@ int bdrv_reopen_set_read_only(BlockDriverState *bs, bool
read_only,
{
QDict *opts = qdict_new();
+ g_assert(qemu_in_main_thread());
+
qdict_put_bool(opts, BDRV_OPT_READ_ONLY, read_only);
return bdrv_reopen(bs, opts, true, errp);
@@ -4720,6 +4766,7 @@ static void bdrv_close(BlockDriverState *bs)
void bdrv_close_all(void)
{
assert(job_next(NULL) == NULL);
+ g_assert(qemu_in_main_thread());
/* Drop references from requests still in flight, such as canceled block
* jobs whose AIO context has not been polled yet */
@@ -5001,11 +5048,15 @@ out:
int bdrv_replace_node(BlockDriverState *from, BlockDriverState *to,
Error **errp)
{
+ g_assert(qemu_in_main_thread());
+
return bdrv_replace_node_common(from, to, true, false, errp);
}
int bdrv_drop_filter(BlockDriverState *bs, Error **errp)
{
+ g_assert(qemu_in_main_thread());
+
return bdrv_replace_node_common(bs, bdrv_filter_or_cow_bs(bs), true, true,
errp);
}
@@ -5028,6 +5079,8 @@ int bdrv_append(BlockDriverState *bs_new,
BlockDriverState *bs_top,
int ret;
Transaction *tran = tran_new();
+ g_assert(qemu_in_main_thread());
+
assert(!bs_new->backing);
ret = bdrv_attach_child_noperm(bs_new, bs_top, "backing",
@@ -5055,6 +5108,7 @@ static void bdrv_delete(BlockDriverState *bs)
{
assert(bdrv_op_blocker_is_empty(bs));
assert(!bs->refcnt);
+ g_assert(qemu_in_main_thread());
/* remove from list, if necessary */
if (bs->node_name[0] != '\0') {
@@ -5073,6 +5127,8 @@ BlockDriverState *bdrv_insert_node(BlockDriverState *bs,
QDict *node_options,
BlockDriverState *new_node_bs;
Error *local_err = NULL;
+ g_assert(qemu_in_main_thread());
+
new_node_bs = bdrv_open(NULL, NULL, node_options, flags, errp);
if (new_node_bs == NULL) {
error_prepend(errp, "Could not create node: ");
@@ -5127,6 +5183,8 @@ int bdrv_change_backing_file(BlockDriverState *bs, const
char *backing_file,
BlockDriver *drv = bs->drv;
int ret;
+ g_assert(qemu_in_main_thread());
+
if (!drv) {
return -ENOMEDIUM;
}
@@ -5168,6 +5226,9 @@ int bdrv_change_backing_file(BlockDriverState *bs, const
char *backing_file,
BlockDriverState *bdrv_find_overlay(BlockDriverState *active,
BlockDriverState *bs)
{
+
+ g_assert(qemu_in_main_thread());
+
bs = bdrv_skip_filters(bs);
active = bdrv_skip_filters(active);
@@ -5185,6 +5246,8 @@ BlockDriverState *bdrv_find_overlay(BlockDriverState
*active,
/* Given a BDS, searches for the base layer. */
BlockDriverState *bdrv_find_base(BlockDriverState *bs)
{
+ g_assert(qemu_in_main_thread());
+
return bdrv_find_overlay(bs, NULL);
}
@@ -5199,6 +5262,8 @@ bool bdrv_is_backing_chain_frozen(BlockDriverState *bs,
BlockDriverState *base,
BlockDriverState *i;
BdrvChild *child;
+ g_assert(qemu_in_main_thread());
+
for (i = bs; i != base; i = child_bs(child)) {
child = bdrv_filter_or_cow_child(i);
@@ -5225,6 +5290,8 @@ int bdrv_freeze_backing_chain(BlockDriverState *bs,
BlockDriverState *base,
BlockDriverState *i;
BdrvChild *child;
+ g_assert(qemu_in_main_thread());
+
if (bdrv_is_backing_chain_frozen(bs, base, errp)) {
return -EPERM;
}
@@ -5259,6 +5326,8 @@ void bdrv_unfreeze_backing_chain(BlockDriverState *bs,
BlockDriverState *base)
BlockDriverState *i;
BdrvChild *child;
+ g_assert(qemu_in_main_thread());
+
for (i = bs; i != base; i = child_bs(child)) {
child = bdrv_filter_or_cow_child(i);
if (child) {
@@ -5308,6 +5377,8 @@ int bdrv_drop_intermediate(BlockDriverState *top,
BlockDriverState *base,
g_autoptr(GSList) updated_children = NULL;
GSList *p;
+ g_assert(qemu_in_main_thread());
+
bdrv_ref(top);
bdrv_subtree_drained_begin(top);
@@ -5519,7 +5590,6 @@ int64_t bdrv_getlength(BlockDriverState *bs)
void bdrv_get_geometry(BlockDriverState *bs, uint64_t *nb_sectors_ptr)
{
int64_t nb_sectors = bdrv_nb_sectors(bs);
-
*nb_sectors_ptr = nb_sectors < 0 ? 0 : nb_sectors;
}
@@ -5569,6 +5639,8 @@ void bdrv_iterate_format(void (*it)(void *opaque, const
char *name),
int i;
const char **formats = NULL;
+ g_assert(qemu_in_main_thread());
+
QLIST_FOREACH(drv, &bdrv_drivers, list) {
if (drv->format_name) {
bool found = false;
@@ -5627,6 +5699,7 @@ BlockDriverState *bdrv_find_node(const char *node_name)
BlockDriverState *bs;
assert(node_name);
+ g_assert(qemu_in_main_thread());
QTAILQ_FOREACH(bs, &graph_bdrv_states, node_list) {
if (!strcmp(node_name, bs->node_name)) {
@@ -5643,6 +5716,8 @@ BlockDeviceInfoList *bdrv_named_nodes_list(bool flat,
BlockDeviceInfoList *list;
BlockDriverState *bs;
+ g_assert(qemu_in_main_thread());
+
list = NULL;
QTAILQ_FOREACH(bs, &graph_bdrv_states, node_list) {
BlockDeviceInfo *info = bdrv_block_device_info(NULL, bs, flat, errp);
@@ -5748,6 +5823,8 @@ XDbgBlockGraph *bdrv_get_xdbg_block_graph(Error **errp)
BdrvChild *child;
XDbgBlockGraphConstructor *gr = xdbg_graph_new();
+ g_assert(qemu_in_main_thread());
+
for (blk = blk_all_next(NULL); blk; blk = blk_all_next(blk)) {
char *allocated_name = NULL;
const char *name = blk_name(blk);
@@ -5791,6 +5868,8 @@ BlockDriverState *bdrv_lookup_bs(const char *device,
BlockBackend *blk;
BlockDriverState *bs;
+ g_assert(qemu_in_main_thread());
+
if (device) {
blk = blk_by_name(device);
@@ -5822,6 +5901,9 @@ BlockDriverState *bdrv_lookup_bs(const char *device,
* return false. If either argument is NULL, return false. */
bool bdrv_chain_contains(BlockDriverState *top, BlockDriverState *base)
{
+
+ g_assert(qemu_in_main_thread());
+
while (top && top != base) {
top = bdrv_filter_or_cow_bs(top);
}
@@ -5831,6 +5913,7 @@ bool bdrv_chain_contains(BlockDriverState *top,
BlockDriverState *base)
BlockDriverState *bdrv_next_node(BlockDriverState *bs)
{
+ g_assert(qemu_in_main_thread());
if (!bs) {
return QTAILQ_FIRST(&graph_bdrv_states);
}
@@ -5839,6 +5922,7 @@ BlockDriverState *bdrv_next_node(BlockDriverState *bs)
BlockDriverState *bdrv_next_all_states(BlockDriverState *bs)
{
+ g_assert(qemu_in_main_thread());
if (!bs) {
return QTAILQ_FIRST(&all_bdrv_states);
}
@@ -5871,6 +5955,7 @@ const char *bdrv_get_parent_name(const BlockDriverState
*bs)
/* TODO check what callers really want: bs->node_name or blk_name() */
const char *bdrv_get_device_name(const BlockDriverState *bs)
{
+ g_assert(qemu_in_main_thread());
return bdrv_get_parent_name(bs) ?: "";
}
@@ -5880,22 +5965,26 @@ const char *bdrv_get_device_name(const BlockDriverState
*bs)
* absent, then this returns an empty (non-null) string. */
const char *bdrv_get_device_or_node_name(const BlockDriverState *bs)
{
+ g_assert(qemu_in_main_thread());
return bdrv_get_parent_name(bs) ?: bs->node_name;
}
int bdrv_get_flags(BlockDriverState *bs)
{
+ g_assert(qemu_in_main_thread());
return bs->open_flags;
}
int bdrv_has_zero_init_1(BlockDriverState *bs)
{
+ g_assert(qemu_in_main_thread());
return 1;
}
int bdrv_has_zero_init(BlockDriverState *bs)
{
BlockDriverState *filtered;
+ g_assert(qemu_in_main_thread());
if (!bs->drv) {
return 0;
@@ -5992,6 +6081,7 @@ void bdrv_debug_event(BlockDriverState *bs, BlkdebugEvent
event)
static BlockDriverState *bdrv_find_debug_node(BlockDriverState *bs)
{
+ g_assert(qemu_in_main_thread());
while (bs && bs->drv && !bs->drv->bdrv_debug_breakpoint) {
bs = bdrv_primary_bs(bs);
}
@@ -6007,6 +6097,7 @@ static BlockDriverState
*bdrv_find_debug_node(BlockDriverState *bs)
int bdrv_debug_breakpoint(BlockDriverState *bs, const char *event,
const char *tag)
{
+ g_assert(qemu_in_main_thread());
bs = bdrv_find_debug_node(bs);
if (bs) {
return bs->drv->bdrv_debug_breakpoint(bs, event, tag);
@@ -6017,6 +6108,7 @@ int bdrv_debug_breakpoint(BlockDriverState *bs, const
char *event,
int bdrv_debug_remove_breakpoint(BlockDriverState *bs, const char *tag)
{
+ g_assert(qemu_in_main_thread());
bs = bdrv_find_debug_node(bs);
if (bs) {
return bs->drv->bdrv_debug_remove_breakpoint(bs, tag);
@@ -6027,6 +6119,7 @@ int bdrv_debug_remove_breakpoint(BlockDriverState *bs,
const char *tag)
int bdrv_debug_resume(BlockDriverState *bs, const char *tag)
{
+ g_assert(qemu_in_main_thread());
while (bs && (!bs->drv || !bs->drv->bdrv_debug_resume)) {
bs = bdrv_primary_bs(bs);
}
@@ -6040,6 +6133,7 @@ int bdrv_debug_resume(BlockDriverState *bs, const char
*tag)
bool bdrv_debug_is_suspended(BlockDriverState *bs, const char *tag)
{
+ g_assert(qemu_in_main_thread());
while (bs && bs->drv && !bs->drv->bdrv_debug_is_suspended) {
bs = bdrv_primary_bs(bs);
}
@@ -6067,6 +6161,8 @@ BlockDriverState
*bdrv_find_backing_image(BlockDriverState *bs,
BlockDriverState *retval = NULL;
BlockDriverState *bs_below;
+ g_assert(qemu_in_main_thread());
+
if (!bs || !bs->drv || !backing_file) {
return NULL;
}
@@ -6165,6 +6261,7 @@ BlockDriverState
*bdrv_find_backing_image(BlockDriverState *bs,
void bdrv_init(void)
{
+ g_assert(qemu_in_main_thread());
#ifdef CONFIG_BDRV_WHITELIST_TOOLS
use_bdrv_whitelist = 1;
#endif
@@ -6173,6 +6270,7 @@ void bdrv_init(void)
void bdrv_init_with_whitelist(void)
{
+ g_assert(qemu_in_main_thread());
use_bdrv_whitelist = 1;
bdrv_init();
}
@@ -6257,6 +6355,8 @@ void bdrv_invalidate_cache_all(Error **errp)
BlockDriverState *bs;
BdrvNextIterator it;
+ g_assert(qemu_in_main_thread());
+
for (bs = bdrv_first(&it); bs; bs = bdrv_next(&it)) {
AioContext *aio_context = bdrv_get_aio_context(bs);
int ret;
@@ -6348,6 +6448,8 @@ int bdrv_inactivate_all(void)
int ret = 0;
GSList *aio_ctxs = NULL, *ctx;
+ g_assert(qemu_in_main_thread());
+
for (bs = bdrv_first(&it); bs; bs = bdrv_next(&it)) {
AioContext *aio_context = bdrv_get_aio_context(bs);
@@ -6425,6 +6527,7 @@ void bdrv_eject(BlockDriverState *bs, bool eject_flag)
void bdrv_lock_medium(BlockDriverState *bs, bool locked)
{
BlockDriver *drv = bs->drv;
+ g_assert(qemu_in_main_thread());
trace_bdrv_lock_medium(bs, locked);
@@ -6436,6 +6539,7 @@ void bdrv_lock_medium(BlockDriverState *bs, bool locked)
/* Get a reference to bs */
void bdrv_ref(BlockDriverState *bs)
{
+ g_assert(qemu_in_main_thread());
bs->refcnt++;
}
@@ -6444,6 +6548,7 @@ void bdrv_ref(BlockDriverState *bs)
* deleted. */
void bdrv_unref(BlockDriverState *bs)
{
+ g_assert(qemu_in_main_thread());
if (!bs) {
return;
}
@@ -6461,6 +6566,7 @@ struct BdrvOpBlocker {
bool bdrv_op_is_blocked(BlockDriverState *bs, BlockOpType op, Error **errp)
{
BdrvOpBlocker *blocker;
+ g_assert(qemu_in_main_thread());
assert((int) op >= 0 && op < BLOCK_OP_TYPE_MAX);
if (!QLIST_EMPTY(&bs->op_blockers[op])) {
blocker = QLIST_FIRST(&bs->op_blockers[op]);
@@ -6475,6 +6581,7 @@ bool bdrv_op_is_blocked(BlockDriverState *bs, BlockOpType
op, Error **errp)
void bdrv_op_block(BlockDriverState *bs, BlockOpType op, Error *reason)
{
BdrvOpBlocker *blocker;
+ g_assert(qemu_in_main_thread());
assert((int) op >= 0 && op < BLOCK_OP_TYPE_MAX);
blocker = g_new0(BdrvOpBlocker, 1);
@@ -6485,6 +6592,7 @@ void bdrv_op_block(BlockDriverState *bs, BlockOpType op,
Error *reason)
void bdrv_op_unblock(BlockDriverState *bs, BlockOpType op, Error *reason)
{
BdrvOpBlocker *blocker, *next;
+ g_assert(qemu_in_main_thread());
assert((int) op >= 0 && op < BLOCK_OP_TYPE_MAX);
QLIST_FOREACH_SAFE(blocker, &bs->op_blockers[op], list, next) {
if (blocker->reason == reason) {
@@ -6497,6 +6605,7 @@ void bdrv_op_unblock(BlockDriverState *bs, BlockOpType
op, Error *reason)
void bdrv_op_block_all(BlockDriverState *bs, Error *reason)
{
int i;
+ g_assert(qemu_in_main_thread());
for (i = 0; i < BLOCK_OP_TYPE_MAX; i++) {
bdrv_op_block(bs, i, reason);
}
@@ -6505,6 +6614,7 @@ void bdrv_op_block_all(BlockDriverState *bs, Error
*reason)
void bdrv_op_unblock_all(BlockDriverState *bs, Error *reason)
{
int i;
+ g_assert(qemu_in_main_thread());
for (i = 0; i < BLOCK_OP_TYPE_MAX; i++) {
bdrv_op_unblock(bs, i, reason);
}
@@ -6513,7 +6623,7 @@ void bdrv_op_unblock_all(BlockDriverState *bs, Error
*reason)
bool bdrv_op_blocker_is_empty(BlockDriverState *bs)
{
int i;
-
+ g_assert(qemu_in_main_thread());
for (i = 0; i < BLOCK_OP_TYPE_MAX; i++) {
if (!QLIST_EMPTY(&bs->op_blockers[i])) {
return false;
@@ -6535,6 +6645,8 @@ void bdrv_img_create(const char *filename, const char
*fmt,
Error *local_err = NULL;
int ret = 0;
+ g_assert(qemu_in_main_thread());
+
/* Find driver and parse its options */
drv = bdrv_find_format(fmt);
if (!drv) {
@@ -6951,6 +7063,7 @@ static bool bdrv_parent_can_set_aio_context(BdrvChild *c,
AioContext *ctx,
bool bdrv_child_can_set_aio_context(BdrvChild *c, AioContext *ctx,
GSList **ignore, Error **errp)
{
+ g_assert(qemu_in_main_thread());
if (g_slist_find(*ignore, c)) {
return true;
}
@@ -6969,6 +7082,8 @@ bool bdrv_can_set_aio_context(BlockDriverState *bs,
AioContext *ctx,
return true;
}
+ g_assert(qemu_in_main_thread());
+
QLIST_FOREACH(c, &bs->parents, next_parent) {
if (!bdrv_parent_can_set_aio_context(c, ctx, ignore, errp)) {
return false;
@@ -6989,6 +7104,8 @@ int bdrv_child_try_set_aio_context(BlockDriverState *bs,
AioContext *ctx,
GSList *ignore;
bool ret;
+ g_assert(qemu_in_main_thread());
+
ignore = ignore_child ? g_slist_prepend(NULL, ignore_child) : NULL;
ret = bdrv_can_set_aio_context(bs, ctx, &ignore, errp);
g_slist_free(ignore);
@@ -7007,6 +7124,7 @@ int bdrv_child_try_set_aio_context(BlockDriverState *bs,
AioContext *ctx,
int bdrv_try_set_aio_context(BlockDriverState *bs, AioContext *ctx,
Error **errp)
{
+ g_assert(qemu_in_main_thread());
return bdrv_child_try_set_aio_context(bs, ctx, NULL, errp);
}
@@ -7020,6 +7138,7 @@ void bdrv_add_aio_context_notifier(BlockDriverState *bs,
.detach_aio_context = detach_aio_context,
.opaque = opaque
};
+ g_assert(qemu_in_main_thread());
QLIST_INSERT_HEAD(&bs->aio_notifiers, ban, list);
}
@@ -7031,6 +7150,7 @@ void bdrv_remove_aio_context_notifier(BlockDriverState
*bs,
void *opaque)
{
BdrvAioNotifier *ban, *ban_next;
+ g_assert(qemu_in_main_thread());
QLIST_FOREACH_SAFE(ban, &bs->aio_notifiers, list, ban_next) {
if (ban->attached_aio_context == attached_aio_context &&
@@ -7055,6 +7175,7 @@ int bdrv_amend_options(BlockDriverState *bs, QemuOpts
*opts,
bool force,
Error **errp)
{
+ g_assert(qemu_in_main_thread());
if (!bs->drv) {
error_setg(errp, "Node is ejected");
return -ENOMEDIUM;
@@ -7125,6 +7246,8 @@ BlockDriverState *check_to_replace_node(BlockDriverState
*parent_bs,
BlockDriverState *to_replace_bs = bdrv_find_node(node_name);
AioContext *aio_context;
+ g_assert(qemu_in_main_thread());
+
if (!to_replace_bs) {
error_setg(errp, "Failed to find node with node-name='%s'", node_name);
return NULL;
@@ -7286,6 +7409,8 @@ void bdrv_refresh_filename(BlockDriverState *bs)
bool generate_json_filename; /* Whether our default implementation should
fill exact_filename (false) or not (true)
*/
+ g_assert(qemu_in_main_thread());
+
if (!drv) {
return;
}
@@ -7408,6 +7533,8 @@ char *bdrv_dirname(BlockDriverState *bs, Error **errp)
BlockDriver *drv = bs->drv;
BlockDriverState *child_bs;
+ g_assert(qemu_in_main_thread());
+
if (!drv) {
error_setg(errp, "Node '%s' is ejected", bs->node_name);
return NULL;
@@ -7439,7 +7566,7 @@ char *bdrv_dirname(BlockDriverState *bs, Error **errp)
void bdrv_add_child(BlockDriverState *parent_bs, BlockDriverState *child_bs,
Error **errp)
{
-
+ g_assert(qemu_in_main_thread());
if (!parent_bs->drv || !parent_bs->drv->bdrv_add_child) {
error_setg(errp, "The node %s does not support adding a child",
bdrv_get_device_or_node_name(parent_bs));
@@ -7459,6 +7586,7 @@ void bdrv_del_child(BlockDriverState *parent_bs,
BdrvChild *child, Error **errp)
{
BdrvChild *tmp;
+ g_assert(qemu_in_main_thread());
if (!parent_bs->drv || !parent_bs->drv->bdrv_del_child) {
error_setg(errp, "The node %s does not support removing a child",
bdrv_get_device_or_node_name(parent_bs));
@@ -7486,6 +7614,7 @@ int bdrv_make_empty(BdrvChild *c, Error **errp)
BlockDriver *drv = c->bs->drv;
int ret;
+ g_assert(qemu_in_main_thread());
assert(c->perm & (BLK_PERM_WRITE | BLK_PERM_WRITE_UNCHANGED));
if (!drv->bdrv_make_empty) {
diff --git a/block/commit.c b/block/commit.c
index 42792b4556..87d7a764d8 100644
--- a/block/commit.c
+++ b/block/commit.c
@@ -433,6 +433,8 @@ int bdrv_commit(BlockDriverState *bs)
QEMU_AUTO_VFREE uint8_t *buf = NULL;
Error *local_err = NULL;
+ g_assert(qemu_in_main_thread());
+
if (!drv)
return -ENOMEDIUM;
diff --git a/block/io.c b/block/io.c
index a19942718b..85242c0302 100644
--- a/block/io.c
+++ b/block/io.c
@@ -163,6 +163,8 @@ void bdrv_refresh_limits(BlockDriverState *bs, Transaction
*tran, Error **errp)
BdrvChild *c;
bool have_limits;
+ g_assert(qemu_in_main_thread());
+
if (tran) {
BdrvRefreshLimitsState *s = g_new(BdrvRefreshLimitsState, 1);
*s = (BdrvRefreshLimitsState) {
@@ -543,6 +545,7 @@ void bdrv_drained_end(BlockDriverState *bs)
void bdrv_drained_end_no_poll(BlockDriverState *bs, int *drained_end_counter)
{
+ g_assert(qemu_in_main_thread());
bdrv_do_drained_end(bs, false, NULL, false, drained_end_counter);
}
@@ -585,12 +588,14 @@ void bdrv_unapply_subtree_drain(BdrvChild *child,
BlockDriverState *old_parent)
void coroutine_fn bdrv_co_drain(BlockDriverState *bs)
{
assert(qemu_in_coroutine());
+ g_assert(qemu_in_main_thread());
bdrv_drained_begin(bs);
bdrv_drained_end(bs);
}
void bdrv_drain(BlockDriverState *bs)
{
+ g_assert(qemu_in_main_thread());
bdrv_drained_begin(bs);
bdrv_drained_end(bs);
}
@@ -611,6 +616,7 @@ static bool bdrv_drain_all_poll(void)
{
BlockDriverState *bs = NULL;
bool result = false;
+ g_assert(qemu_in_main_thread());
/* bdrv_drain_poll() can't make changes to the graph and we are holding the
* main AioContext lock, so iterating bdrv_next_all_states() is safe. */
@@ -639,6 +645,7 @@ static bool bdrv_drain_all_poll(void)
void bdrv_drain_all_begin(void)
{
BlockDriverState *bs = NULL;
+ g_assert(qemu_in_main_thread());
if (qemu_in_coroutine()) {
bdrv_co_yield_to_drain(NULL, true, false, NULL, true, true, NULL);
@@ -695,6 +702,7 @@ void bdrv_drain_all_end(void)
{
BlockDriverState *bs = NULL;
int drained_end_counter = 0;
+ g_assert(qemu_in_main_thread());
/*
* bdrv queue is managed by record/replay,
@@ -722,6 +730,7 @@ void bdrv_drain_all_end(void)
void bdrv_drain_all(void)
{
+ g_assert(qemu_in_main_thread());
bdrv_drain_all_begin();
bdrv_drain_all_end();
}
@@ -2334,6 +2343,8 @@ int bdrv_flush_all(void)
BlockDriverState *bs = NULL;
int result = 0;
+ g_assert(qemu_in_main_thread());
+
/*
* bdrv queue is managed by record/replay,
* creating new flush request for stopping
@@ -2664,6 +2675,7 @@ int bdrv_block_status_above(BlockDriverState *bs,
BlockDriverState *base,
int bdrv_block_status(BlockDriverState *bs, int64_t offset, int64_t bytes,
int64_t *pnum, int64_t *map, BlockDriverState **file)
{
+ g_assert(qemu_in_main_thread());
return bdrv_block_status_above(bs, bdrv_filter_or_cow_bs(bs),
offset, bytes, pnum, map, file);
}
@@ -2733,6 +2745,7 @@ int bdrv_is_allocated_above(BlockDriverState *top,
int64_t bytes, int64_t *pnum)
{
int depth;
+
int ret = bdrv_common_block_status_above(top, base, include_base, false,
offset, bytes, pnum, NULL, NULL,
&depth);
@@ -2797,6 +2810,7 @@ bdrv_co_writev_vmstate(BlockDriverState *bs, QEMUIOVector
*qiov, int64_t pos)
int bdrv_save_vmstate(BlockDriverState *bs, const uint8_t *buf,
int64_t pos, int size)
{
+ g_assert(qemu_in_main_thread());
QEMUIOVector qiov = QEMU_IOVEC_INIT_BUF(qiov, buf, size);
int ret = bdrv_writev_vmstate(bs, &qiov, pos);
@@ -2806,6 +2820,7 @@ int bdrv_save_vmstate(BlockDriverState *bs, const uint8_t
*buf,
int bdrv_load_vmstate(BlockDriverState *bs, uint8_t *buf,
int64_t pos, int size)
{
+ g_assert(qemu_in_main_thread());
QEMUIOVector qiov = QEMU_IOVEC_INIT_BUF(qiov, buf, size);
int ret = bdrv_readv_vmstate(bs, &qiov, pos);
@@ -2817,6 +2832,7 @@ int bdrv_load_vmstate(BlockDriverState *bs, uint8_t *buf,
void bdrv_aio_cancel(BlockAIOCB *acb)
{
+ g_assert(qemu_in_main_thread());
qemu_aio_ref(acb);
bdrv_aio_cancel_async(acb);
while (acb->refcnt > 1) {
@@ -2841,6 +2857,7 @@ void bdrv_aio_cancel(BlockAIOCB *acb)
* In either case the completion callback must be called. */
void bdrv_aio_cancel_async(BlockAIOCB *acb)
{
+ g_assert(qemu_in_main_thread());
if (acb->aiocb_info->cancel_async) {
acb->aiocb_info->cancel_async(acb);
}
@@ -3207,6 +3224,7 @@ void bdrv_register_buf(BlockDriverState *bs, void *host,
size_t size)
{
BdrvChild *child;
+ g_assert(qemu_in_main_thread());
if (bs->drv && bs->drv->bdrv_register_buf) {
bs->drv->bdrv_register_buf(bs, host, size);
}
@@ -3219,6 +3237,7 @@ void bdrv_unregister_buf(BlockDriverState *bs, void *host)
{
BdrvChild *child;
+ g_assert(qemu_in_main_thread());
if (bs->drv && bs->drv->bdrv_unregister_buf) {
bs->drv->bdrv_unregister_buf(bs, host);
}
@@ -3490,6 +3509,7 @@ out:
void bdrv_cancel_in_flight(BlockDriverState *bs)
{
+ g_assert(qemu_in_main_thread());
if (!bs || !bs->drv) {
return;
}
diff --git a/blockdev.c b/blockdev.c
index 3d8ac368a1..44c419545c 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -691,6 +691,7 @@ void blockdev_close_all_bdrv_states(void)
/* Iterates over the list of monitor-owned BlockDriverStates */
BlockDriverState *bdrv_next_monitor_owned(BlockDriverState *bs)
{
+ g_assert(qemu_in_main_thread());
return bs ? QTAILQ_NEXT(bs, monitor_list)
: QTAILQ_FIRST(&monitor_bdrv_states);
}
--
2.27.0
[RFC PATCH v2 05/25] assertions for block global state API,
Emanuele Giuseppe Esposito <=
[RFC PATCH v2 06/25] include/block/block_int: split header into I/O and global state API, Emanuele Giuseppe Esposito, 2021/10/05
[RFC PATCH v2 07/25] assertions for block_int global state API, Emanuele Giuseppe Esposito, 2021/10/05
[RFC PATCH v2 08/25] block: introduce assert_bdrv_graph_writable, Emanuele Giuseppe Esposito, 2021/10/05