Re: [RFC PATCH v2 04/25] include/block/block: split header into I/O and global state API

[Stefan Hajnoczi]

On Tue, Oct 05, 2021 at 10:31:54AM -0400, Emanuele Giuseppe Esposito wrote:
> +int bdrv_pwrite_sync(BdrvChild *child, int64_t offset,
> +                     const void *buf, int64_t bytes);

Why is this bit of a surprise since the other synchronous I/O functions
aren't included in this header. Why did you put it here? This one may be
safe to move to the I/O API.

> +int bdrv_block_status(BlockDriverState *bs, int64_t offset,
> +                      int64_t bytes, int64_t *pnum, int64_t *map,
> +                      BlockDriverState **file);

This function just called bdrv_block_status_above(), which is in the I/O
API. I think it's safe to move this to the I/O API or else
bdrv_block_status_above() shouldn't be there :).

signature.asc
Description: PGP signature