[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/12] block-backend: convert blk_co_pdiscard to int64_t byte
From: |
Eric Blake |
Subject: |
Re: [PATCH 04/12] block-backend: convert blk_co_pdiscard to int64_t bytes |
Date: |
Wed, 6 Oct 2021 10:59:01 -0500 |
User-agent: |
NeoMutt/20210205-815-1dd940 |
On Wed, Oct 06, 2021 at 03:17:10PM +0200, Vladimir Sementsov-Ogievskiy wrote:
> We updated blk_do_pdiscard() and its wrapper blk_co_pdiscard(). Both
> functions are updated so that parameter type becomes wider, so all
> callers should be OK with it.
>
> Look at blk_do_pdiscard(): bytes passed only to
> blk_check_byte_request() and bdrv_co_pdiscard(), which already has
> int64_t bytes parameter, so we are OK.
>
> Note that requests exceeding INT_MAX are still restricted by
> blk_check_byte_request().
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> include/sysemu/block-backend.h | 3 ++-
> block/block-backend.c | 5 +++--
> 2 files changed, 5 insertions(+), 3 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/include/sysemu/block-backend.h b/include/sysemu/block-backend.h
> index 844bb039c5..398e7abb02 100644
> --- a/include/sysemu/block-backend.h
> +++ b/include/sysemu/block-backend.h
> @@ -181,7 +181,8 @@ void blk_aio_cancel_async(BlockAIOCB *acb);
> int blk_ioctl(BlockBackend *blk, unsigned long int req, void *buf);
> BlockAIOCB *blk_aio_ioctl(BlockBackend *blk, unsigned long int req, void
> *buf,
> BlockCompletionFunc *cb, void *opaque);
> -int blk_co_pdiscard(BlockBackend *blk, int64_t offset, int bytes);
> +int coroutine_fn blk_co_pdiscard(BlockBackend *blk, int64_t offset,
> + int64_t bytes);
Commit message didn't mention the addition of this label, but it looks
correct.
> int blk_co_flush(BlockBackend *blk);
I guess fixing blk_co_flush to have the coroutine_fn label would be a
separate patch. Or, you could rearrange the patches to add the label
on multiple functions independently from type changes.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- Re: [PATCH 10/12] block-backend: convert blk_aio_ functions to int64_t bytes paramter, (continued)
[PATCH 11/12] block-backend: blk_pread, blk_pwrite: rename count parameter to bytes, Vladimir Sementsov-Ogievskiy, 2021/10/06
[PATCH 03/12] block-backend: convert blk_co_pwritev_part to int64_t bytes, Vladimir Sementsov-Ogievskiy, 2021/10/06
[PATCH 05/12] block-backend: rename _do_ helper functions to _co_do_, Vladimir Sementsov-Ogievskiy, 2021/10/06
[PATCH 04/12] block-backend: convert blk_co_pdiscard to int64_t bytes, Vladimir Sementsov-Ogievskiy, 2021/10/06
- Re: [PATCH 04/12] block-backend: convert blk_co_pdiscard to int64_t bytes,
Eric Blake <=
[PATCH 12/12] block-backend: drop INT_MAX restriction from blk_check_byte_request(), Vladimir Sementsov-Ogievskiy, 2021/10/06
[PATCH 06/12] block-coroutine-wrapper.py: support BlockBackend first argument, Vladimir Sementsov-Ogievskiy, 2021/10/06
[PATCH 08/12] block-backend: convert blk_foo wrappers to use int64_t bytes parameter, Vladimir Sementsov-Ogievskiy, 2021/10/06
[PATCH 02/12] block-backend: make blk_co_preadv() 64bit, Vladimir Sementsov-Ogievskiy, 2021/10/06
[PATCH 07/12] block-backend: drop blk_prw, use block-coroutine-wrapper, Vladimir Sementsov-Ogievskiy, 2021/10/06