Re: [PATCH 10/12] block-backend: convert blk_aio_ functions to int64_t bytes paramter

[Eric Blake]

On Tue, Oct 12, 2021 at 07:13:23PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> > > @@ -1530,6 +1531,7 @@ BlockAIOCB *blk_aio_preadv(BlockBackend *blk, 
> > > int64_t offset,
> > >                              QEMUIOVector *qiov, BdrvRequestFlags flags,
> > >                              BlockCompletionFunc *cb, void *opaque)
> > >   {
> > > +    assert(qiov->size <= INT64_MAX);
> > 
> > I hope this doesn't cause 32-bit compilers to warn about an
> > always-true expression; but if it does, we'll figure something out.
> > That's not enough for me to ask for you to respin this, though, so:
> > 
> > Reviewed-by: Eric Blake <eblake@redhat.com>
> > 
> 
> So, here we need
> 
> assert((uint64_t)qiov->size <= INT64_MAX);
> 
> as in recent fix by Hanna.
>

Indeed.

> Eric, will you stage this as continuation of 64bit series, or do we wait for 
> Kevin or Hanna, or for me resending it with this small fix and your wording 
> fixes?

At this point, I think I'm fine touching up the series and staging it
through my tree.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org