[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 32/48] tcg/optimize: Split out fold_xi_to_i
From: |
Richard Henderson |
Subject: |
[PATCH v2 32/48] tcg/optimize: Split out fold_xi_to_i |
Date: |
Thu, 7 Oct 2021 12:54:40 -0700 |
Pull the "op r, a, 0 => movi r, 0" optimization into a function,
and use it in the outer opcode fold functions.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/optimize.c | 32 +++++++++++++++-----------------
1 file changed, 15 insertions(+), 17 deletions(-)
diff --git a/tcg/optimize.c b/tcg/optimize.c
index 1ba3a78585..0734bcb42e 100644
--- a/tcg/optimize.c
+++ b/tcg/optimize.c
@@ -695,6 +695,15 @@ static bool fold_const2(OptContext *ctx, TCGOp *op)
return false;
}
+/* If the binary operation has second argument @i, fold to @i. */
+static bool fold_xi_to_i(OptContext *ctx, TCGOp *op, uint64_t i)
+{
+ if (arg_is_const(op->args[2]) && arg_info(op->args[2])->val == i) {
+ return tcg_opt_gen_movi(ctx, op, op->args[0], i);
+ }
+ return false;
+}
+
/* If the binary operation has both arguments equal, fold to @i. */
static bool fold_xx_to_i(OptContext *ctx, TCGOp *op, uint64_t i)
{
@@ -763,6 +772,7 @@ static bool fold_add2_i32(OptContext *ctx, TCGOp *op)
static bool fold_and(OptContext *ctx, TCGOp *op)
{
if (fold_const2(ctx, op) ||
+ fold_xi_to_i(ctx, op, 0) ||
fold_xx_to_x(ctx, op)) {
return true;
}
@@ -1078,7 +1088,11 @@ static bool fold_movcond(OptContext *ctx, TCGOp *op)
static bool fold_multiply(OptContext *ctx, TCGOp *op)
{
- return fold_const2(ctx, op);
+ if (fold_const2(ctx, op) ||
+ fold_xi_to_i(ctx, op, 0)) {
+ return true;
+ }
+ return false;
}
static bool fold_mulu2_i32(OptContext *ctx, TCGOp *op)
@@ -1740,22 +1754,6 @@ void tcg_optimize(TCGContext *s)
continue;
}
- /* Simplify expression for "op r, a, 0 => movi r, 0" cases */
- switch (opc) {
- CASE_OP_32_64_VEC(and):
- CASE_OP_32_64_VEC(mul):
- CASE_OP_32_64(muluh):
- CASE_OP_32_64(mulsh):
- if (arg_is_const(op->args[2])
- && arg_info(op->args[2])->val == 0) {
- tcg_opt_gen_movi(&ctx, op, op->args[0], 0);
- continue;
- }
- break;
- default:
- break;
- }
-
/*
* Process each opcode.
* Sorted alphabetically by opcode as much as possible.
--
2.25.1
- [PATCH v2 07/48] tcg/optimize: Split out copy_propagate, (continued)
- [PATCH v2 07/48] tcg/optimize: Split out copy_propagate, Richard Henderson, 2021/10/07
- [PATCH v2 14/48] tcg/optimize: Split out fold_mb, fold_qemu_{ld,st}, Richard Henderson, 2021/10/07
- [PATCH v2 16/48] tcg/optimize: Split out fold_setcond2, Richard Henderson, 2021/10/07
- [PATCH v2 18/48] tcg/optimize: Split out fold_brcond, Richard Henderson, 2021/10/07
- [PATCH v2 24/48] tcg/optimize: Split out fold_extract, fold_sextract, Richard Henderson, 2021/10/07
- [PATCH v2 32/48] tcg/optimize: Split out fold_xi_to_i,
Richard Henderson <=
- [PATCH v2 30/48] tcg/optimize: Split out fold_xx_to_i, Richard Henderson, 2021/10/07
- [PATCH v2 28/48] tcg/optimize: Split out fold_dup, fold_dup2, Richard Henderson, 2021/10/07
- [PATCH v2 35/48] tcg/optimize: Split out fold_sub_to_neg, Richard Henderson, 2021/10/07
- [PATCH v2 06/48] tcg/optimize: Split out init_arguments, Richard Henderson, 2021/10/07
- [PATCH v2 22/48] tcg/optimize: Split out fold_movcond, Richard Henderson, 2021/10/07
- [PATCH v2 25/48] tcg/optimize: Split out fold_deposit, Richard Henderson, 2021/10/07
- [PATCH v2 12/48] tcg/optimize: Split out finish_folding, Richard Henderson, 2021/10/07