RE: [PATCH v2 16/48] tcg/optimize: Split out fold_setcond2

[Luis Fernando Fujita Pires]

From: Richard Henderson <richard.henderson@linaro.org>
> Reduce some code duplication by folding the NE and EQ cases.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  tcg/optimize.c | 145 ++++++++++++++++++++++++-------------------------
>  1 file changed, 72 insertions(+), 73 deletions(-)

> -                i = do_constant_folding_cond(INDEX_op_setcond_i32,
> -                                             op->args[2], op->args[4],
> -                                             TCG_COND_EQ);
> -                if (i == 0) {
> -                    goto do_setcond_high;
                ^^^^^^^^^
> -                } else if (i < 0) {
> -                    break;
> -                }

I'll just note that the goto in the old code above is wrong - it should be a 
goto to do_setcond_const. But you fixed that in your new implementation.

Reviewed-by: Luis Pires <luis.pires@eldorado.org.br>

--
Luis Pires
Instituto de Pesquisas ELDORADO
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>