[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 03/10] python/aqmp: Return cleared events from EventListener.clear
From: |
John Snow |
Subject: |
[PULL 03/10] python/aqmp: Return cleared events from EventListener.clear() |
Date: |
Tue, 12 Oct 2021 17:41:45 -0400 |
This serves two purposes:
(1) It is now possible to discern whether or not clear() removed any
event(s) from the queue with absolute certainty, and
(2) It is now very easy to get a List of all pending events in one
chunk, which is useful for the sync bridge.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 20210923004938.3999963-4-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
---
python/qemu/aqmp/events.py | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/python/qemu/aqmp/events.py b/python/qemu/aqmp/events.py
index 271899f6b82..5f7150c78d4 100644
--- a/python/qemu/aqmp/events.py
+++ b/python/qemu/aqmp/events.py
@@ -562,7 +562,7 @@ def empty(self) -> bool:
"""
return self._queue.empty()
- def clear(self) -> None:
+ def clear(self) -> List[Message]:
"""
Clear this listener of all pending events.
@@ -570,17 +570,22 @@ def clear(self) -> None:
pending FIFO queue synchronously. It can be also be used to
manually clear any pending events, if desired.
+ :return: The cleared events, if any.
+
.. warning::
Take care when discarding events. Cleared events will be
silently tossed on the floor. All events that were ever
accepted by this listener are visible in `history()`.
"""
+ events = []
while True:
try:
- self._queue.get_nowait()
+ events.append(self._queue.get_nowait())
except asyncio.QueueEmpty:
break
+ return events
+
def __aiter__(self) -> AsyncIterator[Message]:
return self
--
2.31.1
- [PULL 00/10] Python patches, John Snow, 2021/10/12
- [PULL 01/10] python/aqmp: add greeting property to QMPClient, John Snow, 2021/10/12
- [PULL 02/10] python/aqmp: add .empty() method to EventListener, John Snow, 2021/10/12
- [PULL 03/10] python/aqmp: Return cleared events from EventListener.clear(),
John Snow <=
- [PULL 04/10] python/aqmp: add send_fd_scm, John Snow, 2021/10/12
- [PULL 05/10] python/aqmp: Add dict conversion method to Greeting object, John Snow, 2021/10/12
- [PULL 06/10] python/aqmp: Reduce severity of EOFError-caused loop terminations, John Snow, 2021/10/12
- [PULL 07/10] python/aqmp: Disable logging messages by default, John Snow, 2021/10/12
- [PULL 08/10] python/qmp: clear events on get_events() call, John Snow, 2021/10/12
- [PULL 09/10] python/qmp: add send_fd_scm directly to QEMUMonitorProtocol, John Snow, 2021/10/12
- [PULL 10/10] python, iotests: remove socket_scm_helper, John Snow, 2021/10/12
- Re: [PULL 00/10] Python patches, Richard Henderson, 2021/10/12