[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 06/10] python/aqmp: Reduce severity of EOFError-caused loop termin
From: |
John Snow |
Subject: |
[PULL 06/10] python/aqmp: Reduce severity of EOFError-caused loop terminations |
Date: |
Tue, 12 Oct 2021 17:41:48 -0400 |
When we encounter an EOFError, we don't know if it's an "error" in the
perspective of the user of the library yet. Therefore, we should not log
it as an error. Reduce the severity of this logging message to "INFO" to
indicate that it's something that we expect to occur during the normal
operation of the library.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-id: 20210923004938.3999963-7-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
---
python/qemu/aqmp/protocol.py | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/python/qemu/aqmp/protocol.py b/python/qemu/aqmp/protocol.py
index 32e78749c11..ae1df240260 100644
--- a/python/qemu/aqmp/protocol.py
+++ b/python/qemu/aqmp/protocol.py
@@ -721,8 +721,11 @@ async def _bh_loop_forever(self, async_fn: _TaskFN, name:
str) -> None:
self.logger.debug("Task.%s: cancelled.", name)
return
except BaseException as err:
- self.logger.error("Task.%s: %s",
- name, exception_summary(err))
+ self.logger.log(
+ logging.INFO if isinstance(err, EOFError) else logging.ERROR,
+ "Task.%s: %s",
+ name, exception_summary(err)
+ )
self.logger.debug("Task.%s: failure:\n%s\n",
name, pretty_traceback())
self._schedule_disconnect()
--
2.31.1
- [PULL 00/10] Python patches, John Snow, 2021/10/12
- [PULL 01/10] python/aqmp: add greeting property to QMPClient, John Snow, 2021/10/12
- [PULL 02/10] python/aqmp: add .empty() method to EventListener, John Snow, 2021/10/12
- [PULL 03/10] python/aqmp: Return cleared events from EventListener.clear(), John Snow, 2021/10/12
- [PULL 04/10] python/aqmp: add send_fd_scm, John Snow, 2021/10/12
- [PULL 05/10] python/aqmp: Add dict conversion method to Greeting object, John Snow, 2021/10/12
- [PULL 06/10] python/aqmp: Reduce severity of EOFError-caused loop terminations,
John Snow <=
- [PULL 07/10] python/aqmp: Disable logging messages by default, John Snow, 2021/10/12
- [PULL 08/10] python/qmp: clear events on get_events() call, John Snow, 2021/10/12
- [PULL 09/10] python/qmp: add send_fd_scm directly to QEMUMonitorProtocol, John Snow, 2021/10/12
- [PULL 10/10] python, iotests: remove socket_scm_helper, John Snow, 2021/10/12
- Re: [PULL 00/10] Python patches, Richard Henderson, 2021/10/12