[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 13/23] target/mips: Fix single stepping
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v2 13/23] target/mips: Fix single stepping |
|
Date: |
Wed, 13 Oct 2021 00:26:03 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 |
On 10/12/21 18:21, Richard Henderson wrote:
> As per an ancient comment in mips_tr_translate_insn about the
> expectations of gdb, when restarting the insn in a delay slot
> we also re-execute the branch. Which means that we are
> expected to execute two insns in this case.
>
> This has been broken since 8b86d6d2580, where we forced max_insns
> to 1 while single-stepping. This resulted in an exit from the
> translator loop after the branch but before the delay slot is
> translated.
>
> Increase the max_insns to 2 for this case. In addition, bypass
> the end-of-page check, for when the branch itself ends the page.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/mips/tcg/translate.c | 25 ++++++++++++++++---------
> 1 file changed, 16 insertions(+), 9 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- Re: [PATCH v2 02/23] target/alpha: Drop checks for singlestep_enabled, (continued)
- [PATCH v2 03/23] target/avr: Drop checks for singlestep_enabled, Richard Henderson, 2021/10/12
- [PATCH v2 04/23] target/cris: Drop checks for singlestep_enabled, Richard Henderson, 2021/10/12
- [PATCH v2 05/23] target/hexagon: Drop checks for singlestep_enabled, Richard Henderson, 2021/10/12
- [PATCH v2 06/23] target/arm: Drop checks for singlestep_enabled, Richard Henderson, 2021/10/12
- [PATCH v2 07/23] target/hppa: Drop checks for singlestep_enabled, Richard Henderson, 2021/10/12
- [PATCH v2 09/23] target/i386: Drop check for singlestep_enabled, Richard Henderson, 2021/10/12
- [PATCH v2 11/23] target/microblaze: Check CF_NO_GOTO_TB for DISAS_JUMP, Richard Henderson, 2021/10/12
- [PATCH v2 13/23] target/mips: Fix single stepping, Richard Henderson, 2021/10/12
- Re: [PATCH v2 13/23] target/mips: Fix single stepping,
Philippe Mathieu-Daudé <=
- [PATCH v2 15/23] target/openrisc: Drop checks for singlestep_enabled, Richard Henderson, 2021/10/12
- [PATCH v2 10/23] target/m68k: Drop checks for singlestep_enabled, Richard Henderson, 2021/10/12
- [PATCH v2 12/23] target/microblaze: Drop checks for singlestep_enabled, Richard Henderson, 2021/10/12
- [PATCH v2 14/23] target/mips: Drop exit checks for singlestep_enabled, Richard Henderson, 2021/10/12
- [PATCH v2 17/23] target/riscv: Remove dead code after exception, Richard Henderson, 2021/10/12
- [PATCH v2 18/23] target/riscv: Remove exit_tb and lookup_and_goto_ptr, Richard Henderson, 2021/10/12
- [PATCH v2 16/23] target/ppc: Drop exit checks for singlestep_enabled, Richard Henderson, 2021/10/12