[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 13/48] target/sparc: Remove DEBUG_UNALIGNED
From: |
Richard Henderson |
Subject: |
[PATCH v4 13/48] target/sparc: Remove DEBUG_UNALIGNED |
Date: |
Tue, 12 Oct 2021 19:45:32 -0700 |
The printf should have been qemu_log_mask, the parameters
themselves no longer compile, and because this is placed
before unwinding the PC is actively wrong.
We get better (and correct) logging on the other side of
raising the exception, in sparc_cpu_do_interrupt.
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/sparc/ldst_helper.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c
index abe2889d27..2d0d180ea6 100644
--- a/target/sparc/ldst_helper.c
+++ b/target/sparc/ldst_helper.c
@@ -27,7 +27,6 @@
//#define DEBUG_MMU
//#define DEBUG_MXCC
-//#define DEBUG_UNALIGNED
//#define DEBUG_UNASSIGNED
//#define DEBUG_ASI
//#define DEBUG_CACHE_CONTROL
@@ -364,10 +363,6 @@ static void do_check_align(CPUSPARCState *env,
target_ulong addr,
uint32_t align, uintptr_t ra)
{
if (addr & align) {
-#ifdef DEBUG_UNALIGNED
- printf("Unaligned access to 0x" TARGET_FMT_lx " from 0x" TARGET_FMT_lx
- "\n", addr, env->pc);
-#endif
cpu_raise_exception_ra(env, TT_UNALIGNED, ra);
}
}
@@ -1968,10 +1963,6 @@ void QEMU_NORETURN
sparc_cpu_do_unaligned_access(CPUState *cs, vaddr addr,
SPARCCPU *cpu = SPARC_CPU(cs);
CPUSPARCState *env = &cpu->env;
-#ifdef DEBUG_UNALIGNED
- printf("Unaligned access to 0x" TARGET_FMT_lx " from 0x" TARGET_FMT_lx
- "\n", addr, env->pc);
-#endif
cpu_raise_exception_ra(env, TT_UNALIGNED, retaddr);
}
#endif
--
2.25.1
- [PATCH v4 02/48] linux-user: Add cpu_loop_exit_sigbus, (continued)
- [PATCH v4 02/48] linux-user: Add cpu_loop_exit_sigbus, Richard Henderson, 2021/10/12
- [PATCH v4 05/48] linux-user/hppa: Remove EXCP_UNALIGN handling, Richard Henderson, 2021/10/12
- [PATCH v4 06/48] target/microblaze: Do not set MO_ALIGN for user-only, Richard Henderson, 2021/10/12
- [PATCH v4 11/48] linux-user/hppa: Remove POWERPC_EXCP_ALIGN handling, Richard Henderson, 2021/10/12
- [PATCH v4 12/48] target/sh4: Set fault address in superh_cpu_do_unaligned_access, Richard Henderson, 2021/10/12
- [PATCH v4 07/48] target/ppc: Move SPR_DSISR setting to powerpc_excp, Richard Henderson, 2021/10/12
- [PATCH v4 08/48] target/ppc: Set fault address in ppc_cpu_do_unaligned_access, Richard Henderson, 2021/10/12
- [PATCH v4 09/48] target/ppc: Restrict ppc_cpu_do_unaligned_access to sysemu, Richard Henderson, 2021/10/12
- [PATCH v4 10/48] target/s390x: Implement s390x_cpu_record_sigbus, Richard Henderson, 2021/10/12
- [PATCH v4 13/48] target/sparc: Remove DEBUG_UNALIGNED,
Richard Henderson <=
- [PATCH v4 14/48] target/sparc: Split out build_sfsr, Richard Henderson, 2021/10/12
- [PATCH v4 15/48] target/sparc: Set fault address in sparc_cpu_do_unaligned_access, Richard Henderson, 2021/10/12
- [PATCH v4 16/48] accel/tcg: Report unaligned atomics for user-only, Richard Henderson, 2021/10/12
- [PATCH v4 18/48] target/i386: Use MO_128 for 16 byte atomics, Richard Henderson, 2021/10/12
- [PATCH v4 17/48] target/arm: Use MO_128 for 16 byte atomics, Richard Henderson, 2021/10/12
- [PATCH v4 23/48] accel/tcg: Move cpu_atomic decls to exec/cpu_ldst.h, Richard Henderson, 2021/10/12
- [PATCH v4 24/48] target/mips: Use cpu_*_data_ra for msa load/store, Richard Henderson, 2021/10/12
- [PATCH v4 28/48] target/arm: Use cpu_*_mmu instead of helper_*_mmu, Richard Henderson, 2021/10/12
- [PATCH v4 19/48] target/ppc: Use MO_128 for 16 byte atomics, Richard Henderson, 2021/10/12
- [PATCH v4 21/48] target/hexagon: Implement cpu_mmu_index, Richard Henderson, 2021/10/12