Re: [PATCH 6/8] tcg/aarch64: Support TCG_TARGET_SIGNED_ADDR32

[Richard Henderson]

On 10/11/21 3:28 AM, Alex Bennée wrote:
> > +    if (TARGET_LONG_BITS == 64) {
> > +        return 3; /* LSL #0 */
> > +    } else if (signed_addr32) {
> > +        return 6; /* SXTW */
> > +    } else {
> > +        return 2; /* UXTW */
> > +    }
> > +}
>
> If this is is going to be a magic number we pass into our code
> generation we could at least wrap it in a confined enum rather than a
> bare int we chuck around.

Given that it's used exactly one, and commented, and matches the ARM, do we really need an 
enum?


r~