Re: [PATCH v2 05/48] tcg/optimize: Move prev_mb into OptContext

[Richard Henderson]

On 10/19/21 8:44 AM, Alex Bennée wrote:
> > @@ -609,7 +610,7 @@ static bool swap_commutative2(TCGArg *p1, TCGArg *p2)
> >   void tcg_optimize(TCGContext *s)
> >   {
> >       int nb_temps, nb_globals, i;
> > -    TCGOp *op, *op_next, *prev_mb = NULL;
> > +    TCGOp *op, *op_next;
> >       OptContext ctx = { .tcg = s };
>
> Do we need to add .prev_mb = NULL to ensure the ctx doesn't start
> corrupted or does the partial initialisation ensure the rest is zeroed
> out?

All members not explicitly initialized are zeroed.

> Otherwise:
>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

r~