qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 09/48] tcg/optimize: Drop nb_oargs, nb_iargs locals


From: Richard Henderson
Subject: Re: [PATCH v2 09/48] tcg/optimize: Drop nb_oargs, nb_iargs locals
Date: Wed, 20 Oct 2021 19:09:54 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 10/20/21 9:17 AM, Alex Bennée wrote:
+            int nb_oargs = def->nb_oargs;
              for (i = 0; i < nb_oargs; i++) {

nit: couldn't you just do for (i = 0; i < deb->nb_oargs; i++) or is that
too much for the compiler to wrap it's head around?'

That leaves the compiler with non-invariant loop bounds, because memory clobbering inside the loop.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]