Re: [PATCH 3/6] numa: Add SGXEPCSection list for multiple sections

[Yang Zhong]

On Mon, Oct 11, 2021 at 12:03:24PM -0500, Eric Blake wrote:
> On Mon, Oct 11, 2021 at 07:15:51PM +0800, Yang Zhong wrote:
> > The SGXEPCSection list added into SGXInfo to show the multiple
> > SGX EPC sections detailed info, not the total size like before.
> > 
> > Signed-off-by: Yang Zhong <yang.zhong@intel.com>
> > ---
> >  qapi/misc-target.json | 19 +++++++++++++++++--
> >  1 file changed, 17 insertions(+), 2 deletions(-)
> > 
> > diff --git a/qapi/misc-target.json b/qapi/misc-target.json
> > index 594fbd1577..89a5a4250a 100644
> > --- a/qapi/misc-target.json
> > +++ b/qapi/misc-target.json
> > @@ -334,6 +334,21 @@
> >    'returns': 'SevAttestationReport',
> >    'if': 'TARGET_I386' }
> >  
> > +##
> > +# @SGXEPCSection:
> > +#
> > +# Information about intel SGX EPC section info
> > +#
> > +# @index: the SGX epc section index
> > +#
> > +# @size: the size of epc section
> > +#
> > +# Since: 6.2
> > +##
> > +{ 'struct': 'SGXEPCSection',
> > +  'data': { 'index': 'uint64',
> > +            'size': 'uint64'}}
> > +
> >  ##
> >  # @SGXInfo:
> >  #
> > @@ -347,7 +362,7 @@
> >  #
> >  # @flc: true if FLC is supported
> >  #
> > -# @section-size: The EPC section size for guest
> > +# @sections: The EPC sections info for guest
> >  #
> >  # Since: 6.2
> 
> Given this has not yet been in a stable release, we can make this change...
> 

  The basic SGX is only suitable for one vepc section to guest. This new 
patchset
  need support NUMA function with multiple vepc to guest. So we need detailed 
epc
  or vepc section info. Thanks!

  Yang


> >  ##
> > @@ -356,7 +371,7 @@
> >              'sgx1': 'bool',
> >              'sgx2': 'bool',
> >              'flc': 'bool',
> > -            'section-size': 'uint64'},
> > +            'sections': ['SGXEPCSection']},
> >     'if': 'TARGET_I386' }
> 
> ...but are we sure we have the best interface possible if we are still
> expressing uncertainty about the QAPI used to represent it?
> 
  
  Yes, we need more accurate definition to handle this. Paolo suggested
  to use the numa node to replace this index, which is much better. Let
  me change this in next version, thanks! 

  Yang

> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3266
> Virtualization:  qemu.org | libvirt.org