Re: [PATCH 3/6] numa: Add SGXEPCSection list for multiple sections

[Yang Zhong]

On Tue, Oct 12, 2021 at 01:01:34PM +0200, Paolo Bonzini wrote:
> On 11/10/21 13:15, Yang Zhong wrote:
> >The SGXEPCSection list added into SGXInfo to show the multiple
> >SGX EPC sections detailed info, not the total size like before.
> >
> >Signed-off-by: Yang Zhong <yang.zhong@intel.com>
> >---
> >  qapi/misc-target.json | 19 +++++++++++++++++--
> >  1 file changed, 17 insertions(+), 2 deletions(-)
> >
> >diff --git a/qapi/misc-target.json b/qapi/misc-target.json
> >index 594fbd1577..89a5a4250a 100644
> >--- a/qapi/misc-target.json
> >+++ b/qapi/misc-target.json
> >@@ -334,6 +334,21 @@
> >    'returns': 'SevAttestationReport',
> >    'if': 'TARGET_I386' }
> >+##
> >+# @SGXEPCSection:
> >+#
> >+# Information about intel SGX EPC section info
> >+#
> >+# @index: the SGX epc section index
> >+#
> >+# @size: the size of epc section
> >+#
> >+# Since: 6.2
> >+##
> >+{ 'struct': 'SGXEPCSection',
> >+  'data': { 'index': 'uint64',
> >+            'size': 'uint64'}}
> >+
> >  ##
> >  # @SGXInfo:
> >  #
> >@@ -347,7 +362,7 @@
> >  #
> >  # @flc: true if FLC is supported
> >  #
> >-# @section-size: The EPC section size for guest
> >+# @sections: The EPC sections info for guest
> >  #
> >  # Since: 6.2
> >  ##
> >@@ -356,7 +371,7 @@
> >              'sgx1': 'bool',
> >              'sgx2': 'bool',
> >              'flc': 'bool',
> >-            'section-size': 'uint64'},
> >+            'sections': ['SGXEPCSection']},
> >     'if': 'TARGET_I386' }
> >  ##
> >
> 
> I am not sure the index is particularly useful, but perhaps you
> should add the node there?
>

  Good point! The node is much better than index here. thanks!

  Yang

 
> Paolo