[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 33/33] target/mips: Adjust style in msa_translate_init()
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 33/33] target/mips: Adjust style in msa_translate_init() |
Date: |
Sat, 23 Oct 2021 23:48:03 +0200 |
While the first 'off' variable assignment is unused, it helps
to better understand the code logic. Move the assignation where
it would have been used so it is easier to compare the MSA
registers based on FPU ones versus the MSA specific registers.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
target/mips/tcg/msa_translate.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translate.c
index 5d8cad378e6..d196cad196b 100644
--- a/target/mips/tcg/msa_translate.c
+++ b/target/mips/tcg/msa_translate.c
@@ -80,13 +80,15 @@ void msa_translate_init(void)
int i;
for (i = 0; i < 32; i++) {
- int off = offsetof(CPUMIPSState, active_fpu.fpr[i].wr.d[0]);
+ int off;
/*
* The MSA vector registers are mapped on the
* scalar floating-point unit (FPU) registers.
*/
+ off = offsetof(CPUMIPSState, active_fpu.fpr[i].wr.d[0]);
msa_wr_d[i * 2] = fpu_f64[i];
+
off = offsetof(CPUMIPSState, active_fpu.fpr[i].wr.d[1]);
msa_wr_d[i * 2 + 1] =
tcg_global_mem_new_i64(cpu_env, off, msaregnames[i * 2 + 1]);
--
2.31.1
- [PATCH 29/33] target/mips: Convert MSA MOVE.V opcode to decodetree, (continued)
- [PATCH 29/33] target/mips: Convert MSA MOVE.V opcode to decodetree, Philippe Mathieu-Daudé, 2021/10/23
- [PATCH 28/33] target/mips: Convert MSA COPY_S and INSERT opcodes to decodetree, Philippe Mathieu-Daudé, 2021/10/23
- [PATCH 30/33] target/mips: Convert CFCMSA and CTCMSA opcodes to decodetree, Philippe Mathieu-Daudé, 2021/10/23
- [PATCH 31/33] target/mips: Remove generic MSA opcode, Philippe Mathieu-Daudé, 2021/10/23
- [PATCH 32/33] target/mips: Remove one MSA unnecessary decodetree overlap group, Philippe Mathieu-Daudé, 2021/10/23
- [PATCH 33/33] target/mips: Adjust style in msa_translate_init(),
Philippe Mathieu-Daudé <=
- Re: [PATCH 00/33] target/mips: Fully convert MSA opcodes to decodetree, Jiaxun Yang, 2021/10/24