Re: [PATCH v1 22/28] tracing: remove TCG memory access tracing

[Richard Henderson]

On 10/26/21 3:22 AM, Alex Bennée wrote:
> @@ -950,7 +948,6 @@ uint32_t cpu_ldl_be_mmu(CPUArchState *env, abi_ptr addr,
>       uint32_t ret;
>   
>       validate_memop(oi, MO_BEUL);
> -    trace_guest_ld_before_exec(env_cpu(env), addr, oi);
>       haddr = cpu_mmu_lookup(env, addr, oi, ra, MMU_DATA_LOAD);
>       ret = ldl_be_p(haddr);
>       clear_helper_retaddr();
> @@ -965,7 +962,7 @@ uint64_t cpu_ldq_be_mmu(CPUArchState *env, abi_ptr addr,
>       uint64_t ret;
>   
>       validate_memop(oi, MO_BEQ);
> -    trace_guest_ld_before_exec(env_cpu(env), addr, oi);
> +
>       haddr = cpu_mmu_lookup(env, addr, oi, ra, MMU_DATA_LOAD);
>       ret = ldq_be_p(haddr);
>       clear_helper_retaddr();
> @@ -980,7 +977,6 @@ uint16_t cpu_ldw_le_mmu(CPUArchState *env, abi_ptr addr,
>       uint16_t ret;
>   
>       validate_memop(oi, MO_LEUW);
> -    trace_guest_ld_before_exec(env_cpu(env), addr, oi);
>       haddr = cpu_mmu_lookup(env, addr, oi, ra, MMU_DATA_LOAD);
>       ret = lduw_le_p(haddr);
>       clear_helper_retaddr();

In that one instance you add an extra line.  Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~