qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 27/28] tests/tcg: remove duplicate EXTRA_RUNS


From: Alex Bennée
Subject: Re: [PATCH v1 27/28] tests/tcg: remove duplicate EXTRA_RUNS
Date: Wed, 27 Oct 2021 15:48:28 +0100
User-agent: mu4e 1.7.4; emacs 28.0.60

Richard Henderson <richard.henderson@linaro.org> writes:

> On 10/26/21 3:22 AM, Alex Bennée wrote:
>> We set it bellow outside the #if leg.
>> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
>> ---
>>   tests/tcg/multiarch/Makefile.target | 2 --
>>   1 file changed, 2 deletions(-)
>
> Surely it's better to have them inside the IF?
> Why add tests that we're definitely going to SKIP?

At least this way you get a visual indication of tests that are skipped
(and you might be able to do something about that).


-- 
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]