qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/1] gitlab-ci: Only push docker images to registry from /mas


From: Thomas Huth
Subject: Re: [PATCH 1/1] gitlab-ci: Only push docker images to registry from /master branch
Date: Wed, 27 Oct 2021 08:01:07 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0

On 26/10/2021 16.55, Philippe Mathieu-Daudé wrote:
Users expect images pulled from registry.gitlab.com/qemu-project/qemu/
to be stable. QEMU repository workflow pushes merge candidates to
the /staging branch, and on success the same commit is pushed as
/master. If /staging fails, we do not want to push the built images
to the registry. Therefore limit the 'docker push' command to the
/master branch on the mainstream CI. The fork behavior is unchanged.

Hmmm, what if I have a patch series that updates one of the containers and then also contains a new test that depends on the updated container? Won't that fail in the staging branch now and make me look bad?

 Thomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]