[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/1] gitlab-ci: Only push docker images to mainstream registr
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 0/1] gitlab-ci: Only push docker images to mainstream registry from /master |
Date: |
Wed, 27 Oct 2021 15:02:14 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
On 10/27/21 14:34, Daniel P. Berrangé wrote:
> On Wed, Oct 27, 2021 at 02:26:58PM +0200, Gerd Hoffmann wrote:
>>> Notably the latter is more restrictive that git branch names. We could
>>> assume users always have "sensible" branch names that are less than
>>> 128 chars and only alpha-num characters plus dash/underscore. This
>>> would be fine for my personal branch naming, but I wonder if anyone
>>> uses wierd branch names that would violate docker tag name rules ?
>>
>> /me uses slashes in branch names, i.e.
>>
>> queue/$topic for patch queues
>> $hostname/$subject for my development branches.
>
> Ok, good to know. So that example clearly rules out use of git branch
> names as docker tags.
CI_COMMIT_REF_SLUG should work:
- CI_COMMIT_REF_NAME The branch or tag name for which project is built.
- CI_COMMIT_REF_NAME in lowercase, shortened to 63 bytes, and with
everything except 0-9 and a-z replaced with -.
No leading / trailing -. Use in URLs, host names and domain names.
- [PATCH 1/1] gitlab-ci: Only push docker images to registry from /master branch, (continued)
Re: [PATCH 0/1] gitlab-ci: Only push docker images to mainstream registry from /master, Daniel P . Berrangé, 2021/10/27