Re: [PATCH] target/avr: Optimize various functions using extract opcode

[Michael Rolnik]

hi Philippe

how was it tested?

On Wed, Oct 27, 2021 at 7:42 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:

Hi Richard,

On 10/3/21 17:24, Richard Henderson wrote:
> On 10/3/21 10:21 AM, Philippe Mathieu-Daudé wrote:
>> When running the scripts/coccinelle/tcg_gen_extract.cocci
>> Coccinelle semantic patch on target/avr/, we get:
>>
>>    [DBG] candidate at target/avr/translate.c:228
>>    [DBG] candidate at target/avr/translate.c:266
>>    [DBG] candidate at target/avr/translate.c:885
>>    [DBG] candidate at target/avr/translate.c:924
>>    [DBG] candidate at target/avr/translate.c:962
>>
>> Manually inspect and replace combinations of (shri, andi)
>> opcodes by the extract opcode.
>>
>> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
>> ---
>>   target/avr/translate.c | 16 +++++-----------
>>   1 file changed, 5 insertions(+), 11 deletions(-)
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Do you mind taking this patch via tcg-next?

--

Best Regards,
Michael Rolnik