[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 6/8] iotests/300: avoid abnormal shutdown race condition
|
From: |
Kevin Wolf |
|
Subject: |
Re: [PATCH v5 6/8] iotests/300: avoid abnormal shutdown race condition |
|
Date: |
Wed, 27 Oct 2021 14:56:46 +0200 |
Am 26.10.2021 um 19:56 hat John Snow geschrieben:
> Wait for the destination VM to close itself instead of racing to shut it
> down first, which produces different error log messages from AQMP
> depending on precisely when we tried to shut it down.
>
> (For example: We may try to issue 'quit' immediately prior to the target
> VM closing its QMP socket, which will cause an ECONNRESET error to be
> logged. Waiting for the VM to exit itself avoids the race on shutdown
> behavior.)
>
> Reported-by: Hanna Reitz <hreitz@redhat.com>
> Signed-off-by: John Snow <jsnow@redhat.com>
I think this will still expose the race I described in my comment on
patch 2.
Kevin
- [PATCH v5 0/8] Switch iotests to using Async QMP, John Snow, 2021/10/26
- [PATCH v5 6/8] iotests/300: avoid abnormal shutdown race condition, John Snow, 2021/10/26
- Re: [PATCH v5 6/8] iotests/300: avoid abnormal shutdown race condition,
Kevin Wolf <=
- [PATCH v5 7/8] python/aqmp: Create sync QMP wrapper for iotests, John Snow, 2021/10/26
- [PATCH v5 4/8] iotests: Accommodate async QMP Exception classes, John Snow, 2021/10/26
- [PATCH v5 8/8] python, iotests: replace qmp with aqmp, John Snow, 2021/10/26
- [PATCH v5 3/8] python/aqmp: Remove scary message, John Snow, 2021/10/26
- [PATCH v5 5/8] iotests: Conditionally silence certain AQMP errors, John Snow, 2021/10/26
- Re: [PATCH v5 0/8] Switch iotests to using Async QMP, Kevin Wolf, 2021/10/28