[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 0/8] Switch iotests to using Async QMP
|
From: |
Kevin Wolf |
|
Subject: |
Re: [PATCH v5 0/8] Switch iotests to using Async QMP |
|
Date: |
Thu, 28 Oct 2021 12:37:46 +0200 |
Am 26.10.2021 um 19:56 hat John Snow geschrieben:
> GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-aqmp-iotest-wrapper
> CI: https://gitlab.com/jsnow/qemu/-/pipelines/395925703
>
> Hiya,
>
> This series continues where the last two AQMP series left off and adds a
> synchronous 'legacy' wrapper around the new AQMP interface, then drops
> it straight into iotests to prove that AQMP is functional and totally
> cool and fine. The disruption and churn to iotests is pretty minimal.
>
> In the event that a regression happens and I am not physically proximate
> to inflict damage upon, one may set the QEMU_PYTHON_LEGACY_QMP variable
> to any non-empty string as it pleases you to engage the QMP machinery
> you are used to.
I obviously haven't reviewed systematically that AQMP is actually
correctly implemented and does what this series expects it to do, but
treating it as a black box should be good enough for this series:
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
- Re: [PATCH v5 2/8] python/machine: Handle QMP errors on close more meticulously, (continued)
[PATCH v5 6/8] iotests/300: avoid abnormal shutdown race condition, John Snow, 2021/10/26
[PATCH v5 7/8] python/aqmp: Create sync QMP wrapper for iotests, John Snow, 2021/10/26
[PATCH v5 4/8] iotests: Accommodate async QMP Exception classes, John Snow, 2021/10/26
[PATCH v5 8/8] python, iotests: replace qmp with aqmp, John Snow, 2021/10/26
[PATCH v5 3/8] python/aqmp: Remove scary message, John Snow, 2021/10/26
[PATCH v5 5/8] iotests: Conditionally silence certain AQMP errors, John Snow, 2021/10/26
Re: [PATCH v5 0/8] Switch iotests to using Async QMP,
Kevin Wolf <=