[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 10/32] target/mips: Convert MSA BIT instruction format to
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v2 10/32] target/mips: Convert MSA BIT instruction format to decodetree |
|
Date: |
Thu, 28 Oct 2021 13:04:00 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
On 10/27/21 23:20, Richard Henderson wrote:
> On 10/27/21 11:07 AM, Philippe Mathieu-Daudé wrote:
>> +static bool trans_msa_bit(DisasContext *ctx, arg_msa_bit *a,
>> + gen_helper_piiii *gen_msa_bit)
>> {
>> + if (a->df < 0) {
>> + return false;
>> }
>
> This test should happen before the msa check...
>> + gen_msa_bit(cpu_env,
>> + tcg_constant_i32(a->df),
>> + tcg_constant_i32(a->wd),
>> + tcg_constant_i32(a->ws),
>> + tcg_constant_i32(a->m));
>> + return true;
>> }
>> +TRANS_MSA(SLLI, trans_msa_bit, gen_helper_msa_slli_df);
>
> ... currently being hidden in here.
>
> This is the reason why I suggest TRANS_MSA be dispensed with. You won't
> have over-many explicit trans_* functions in which you need to place the
> msa check, I think.
Yes, you are right.
- [PATCH v2 01/32] target/mips: Fix MSA MADDV.B opcode, (continued)
- [PATCH v2 01/32] target/mips: Fix MSA MADDV.B opcode, Philippe Mathieu-Daudé, 2021/10/27
- [PATCH v2 03/32] tests/tcg/mips: Run MSA opcodes tests on user-mode emulation, Philippe Mathieu-Daudé, 2021/10/27
- [PATCH v2 04/32] target/mips: Use dup_const() to simplify, Philippe Mathieu-Daudé, 2021/10/27
- [PATCH v2 05/32] target/mips: Have check_msa_access() return a boolean, Philippe Mathieu-Daudé, 2021/10/27
- [PATCH v2 06/32] target/mips: Use enum definitions from CPUMIPSMSADataFormat enum, Philippe Mathieu-Daudé, 2021/10/27
- [PATCH v2 07/32] target/mips: Rename sa16 -> sa, bz_df -> bz -> bz_v, Philippe Mathieu-Daudé, 2021/10/27
- [PATCH v2 10/32] target/mips: Convert MSA BIT instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/27
- [PATCH v2 12/32] target/mips: Convert MSA I8 instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/27
- [PATCH v2 11/32] target/mips: Convert MSA SHF opcode to decodetree, Philippe Mathieu-Daudé, 2021/10/27
- [PATCH v2 08/32] target/mips: Convert MSA LDI opcode to decodetree, Philippe Mathieu-Daudé, 2021/10/27
- [PATCH v2 09/32] target/mips: Convert MSA I5 instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/27
- [PATCH v2 13/32] target/mips: Convert MSA load/store instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/27