[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 11/32] target/mips: Convert MSA SHF opcode to decodetree
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v2 11/32] target/mips: Convert MSA SHF opcode to decodetree |
|
Date: |
Thu, 28 Oct 2021 13:45:16 +0200 |
On Wed, Oct 27, 2021 at 11:21 PM Richard Henderson
<richard.henderson@linaro.org> wrote:
> On 10/27/21 11:07 AM, Philippe Mathieu-Daudé wrote:
> > +static bool trans_SHF(DisasContext *ctx, arg_msa_i8 *a)
> > +{
> > + if (a->df == DF_DOUBLE) {
> > + gen_reserved_instruction(ctx);
> > + return true;
> > + }
>
> Here you have the option to return false, as you choose.
Yes, I prefer to return false. Thanks for re-reviewing patches where I
included your R-b tag :)
- Re: [PATCH v2 05/32] target/mips: Have check_msa_access() return a boolean, (continued)
- [PATCH v2 06/32] target/mips: Use enum definitions from CPUMIPSMSADataFormat enum, Philippe Mathieu-Daudé, 2021/10/27
- [PATCH v2 07/32] target/mips: Rename sa16 -> sa, bz_df -> bz -> bz_v, Philippe Mathieu-Daudé, 2021/10/27
- [PATCH v2 10/32] target/mips: Convert MSA BIT instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/27
- [PATCH v2 12/32] target/mips: Convert MSA I8 instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/27
- [PATCH v2 11/32] target/mips: Convert MSA SHF opcode to decodetree, Philippe Mathieu-Daudé, 2021/10/27
- [PATCH v2 08/32] target/mips: Convert MSA LDI opcode to decodetree, Philippe Mathieu-Daudé, 2021/10/27
- [PATCH v2 09/32] target/mips: Convert MSA I5 instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/27
- [PATCH v2 13/32] target/mips: Convert MSA load/store instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/27
- [PATCH v2 14/32] target/mips: Convert MSA 2RF instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/27
- [PATCH v2 15/32] target/mips: Convert MSA FILL opcode to decodetree, Philippe Mathieu-Daudé, 2021/10/27
- [PATCH v2 16/32] target/mips: Convert MSA 2R instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/27