Re: [PATCH v2 09/32] target/mips: Convert MSA I5 instruction format to decodetree

[Richard Henderson]

On 10/27/21 11:07 AM, Philippe Mathieu-Daudé wrote:
> Convert instructions with a 5-bit immediate value to decodetree.
>
> Since the 'data format' field is a constant value, use
> tcg_constant_i32() instead of a TCG temporary.
>
> Reviewed-by: Richard Henderson<richard.henderson@linaro.org>
> Reviewed-by: Jiaxun Yang<jiaxun.yang@flygoat.com>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
> v2:
> - add &msa_i5 format
> - TRANS_MSA() calls check_msa_enabled()
> - TCG timm is constant
> ---
>   target/mips/tcg/msa.decode      |  16 +++++
>   target/mips/tcg/msa_translate.c | 114 ++++++++++----------------------
>   2 files changed, 52 insertions(+), 78 deletions(-)

I think you should drop TRANS_MSA and include the check in trans_msa_i5 
instead.  Otherwise,

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~