[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v4 38/51] tcg/optimize: Split out fold_masks
From: |
Luis Fernando Fujita Pires |
Subject: |
RE: [PATCH v4 38/51] tcg/optimize: Split out fold_masks |
Date: |
Wed, 27 Oct 2021 13:37:19 +0000 |
From: Richard Henderson <richard.henderson@linaro.org>
> @@ -1084,7 +1215,15 @@ static bool fold_extract(OptContext *ctx, TCGOp
> *op)
> t = extract64(t, op->args[2], op->args[3]);
> return tcg_opt_gen_movi(ctx, op, op->args[0], t);
> }
> - return false;
> +
> + z_mask_old = arg_info(op->args[1])->z_mask;
> + z_mask = sextract64(z_mask_old, op->args[2], op->args[3]);
Should this be extract64 instead of sextract64?
Otherwise,
Reviewed-by: Luis Pires <luis.pires@eldorado.org.br>
--
Luis Pires
Instituto de Pesquisas ELDORADO
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>
- [PATCH v4 39/51] tcg/optimize: Expand fold_mulu2_i32 to all 4-arg multiplies, (continued)
- [PATCH v4 39/51] tcg/optimize: Expand fold_mulu2_i32 to all 4-arg multiplies, Richard Henderson, 2021/10/26
- [PATCH v4 25/51] tcg/optimize: Split out fold_deposit, Richard Henderson, 2021/10/26
- [PATCH v4 31/51] tcg/optimize: Split out fold_xx_to_x, Richard Henderson, 2021/10/26
- [PATCH v4 30/51] tcg/optimize: Split out fold_xx_to_i, Richard Henderson, 2021/10/26
- [PATCH v4 34/51] tcg/optimize: Split out fold_to_not, Richard Henderson, 2021/10/26
- [PATCH v4 33/51] tcg/optimize: Add type to OptContext, Richard Henderson, 2021/10/26
- [PATCH v4 37/51] tcg/optimize: Split out fold_ix_to_i, Richard Henderson, 2021/10/26
- [PATCH v4 38/51] tcg/optimize: Split out fold_masks, Richard Henderson, 2021/10/26
- RE: [PATCH v4 38/51] tcg/optimize: Split out fold_masks,
Luis Fernando Fujita Pires <=
- [PATCH v4 32/51] tcg/optimize: Split out fold_xi_to_i, Richard Henderson, 2021/10/26
- [PATCH v4 36/51] tcg/optimize: Split out fold_xi_to_x, Richard Henderson, 2021/10/26
- [PATCH v4 41/51] tcg/optimize: Sink commutative operand swapping into fold functions, Richard Henderson, 2021/10/26
- [PATCH v4 40/51] tcg/optimize: Expand fold_addsub2_i32 to 64-bit ops, Richard Henderson, 2021/10/26
- [PATCH v4 44/51] tcg/optimize: Use fold_xi_to_x for mul, Richard Henderson, 2021/10/26