qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH v4 38/51] tcg/optimize: Split out fold_masks


From: Luis Fernando Fujita Pires
Subject: RE: [PATCH v4 38/51] tcg/optimize: Split out fold_masks
Date: Wed, 27 Oct 2021 13:37:19 +0000

From: Richard Henderson <richard.henderson@linaro.org>

> @@ -1084,7 +1215,15 @@ static bool fold_extract(OptContext *ctx, TCGOp
> *op)
>          t = extract64(t, op->args[2], op->args[3]);
>          return tcg_opt_gen_movi(ctx, op, op->args[0], t);
>      }
> -    return false;
> +
> +    z_mask_old = arg_info(op->args[1])->z_mask;
> +    z_mask = sextract64(z_mask_old, op->args[2], op->args[3]);

Should this be extract64 instead of sextract64?

Otherwise,
Reviewed-by: Luis Pires <luis.pires@eldorado.org.br>

--
Luis Pires
Instituto de Pesquisas ELDORADO
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]