Re: [PATCH v4 38/51] tcg/optimize: Split out fold_masks

[Richard Henderson]

On 10/27/21 6:37 AM, Luis Fernando Fujita Pires wrote:
> From: Richard Henderson <richard.henderson@linaro.org>
>
> > @@ -1084,7 +1215,15 @@ static bool fold_extract(OptContext *ctx, TCGOp
> > *op)
> >           t = extract64(t, op->args[2], op->args[3]);
> >           return tcg_opt_gen_movi(ctx, op, op->args[0], t);
> >       }
> > -    return false;
> > +
> > +    z_mask_old = arg_info(op->args[1])->z_mask;
> > +    z_mask = sextract64(z_mask_old, op->args[2], op->args[3]);
>
> Should this be extract64 instead of sextract64?

Quite right, thanks.

r~

> Otherwise,
> Reviewed-by: Luis Pires <luis.pires@eldorado.org.br>
>
> --
> Luis Pires
> Instituto de Pesquisas ELDORADO
> Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>