Re: [PATCH 2/2] build: use "meson test" as the test harness

[Thomas Huth]

On 28/10/2021 16.28, Paolo Bonzini wrote:
> "meson test" starting with version 0.57 is just as capable and easy to
> use as QEMU's own TAP driver.  All existing options for "make check"
> work.  The only required code change involves how to mark "slow" tests.
>
> The rules for .tap output are replaced by JUnit XML; GitLab is able
> to parse that output and present it in the CI pipeline report.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   Makefile              |   3 +-
>   meson.build           |   5 +-
>   scripts/mtest2make.py | 104 ++++--------
>   scripts/tap-driver.pl | 379 ------------------------------------------
>   scripts/tap-merge.pl  | 111 -------------
>   tests/fp/meson.build  |   2 +-
>   6 files changed, 41 insertions(+), 563 deletions(-)
>   delete mode 100755 scripts/tap-driver.pl
>   delete mode 100755 scripts/tap-merge.pl
[...]
> diff --git a/tests/fp/meson.build b/tests/fp/meson.build
> index 07e2cdc8d2..32d57031fc 100644
> --- a/tests/fp/meson.build
> +++ b/tests/fp/meson.build
> @@ -622,7 +622,7 @@ test('fp-test-mulAdd', fptest,
>        # no fptest_rounding_args
>        args: fptest_args +
>              ['f16_mulAdd', 'f32_mulAdd', 'f64_mulAdd', 'f128_mulAdd'],
> -     suite: ['softfloat-slow', 'softfloat-ops-slow'], timeout: 90)
> +     suite: ['softfloat', 'softfloat-ops', 'slow'], timeout: 90)
>   
>   fpbench = executable(
>     'fp-bench',

Thanks for the update, this works definitely better than the RFC already. 
However, I spotted another oddity: "make check-softfloat" now is way slower 
than before, it takes more than 2 minutes now, while it finished within 20 
seconds before your change ... looks like you've included some slow tests 
into the normal run now?

 Thomas