[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] tcg: Extend call args using the correct opcodes
From: |
Richard Henderson |
Subject: |
[PATCH] tcg: Extend call args using the correct opcodes |
Date: |
Thu, 28 Oct 2021 11:44:40 -0700 |
Pretending that the source is i64 when it is in fact i32 is
incorrect; we have type-changing opcodes that must be used.
This bug trips up the subsequent change to the optimizer.
Fixes: 4f2331e5b67a
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
This fixes a problem found in s390x host testing, and should
be considered patch 41.5/51 in
[PATCH v4 00/51] tcg: optimize redundant sign extensions
just before
tcg/optimize: Stop forcing z_mask to "garbage" for 32-bit values
r~
---
tcg/tcg.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tcg/tcg.c b/tcg/tcg.c
index 024a22cf39..6332cdceca 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -1508,11 +1508,11 @@ void tcg_gen_callN(void *func, TCGTemp *ret, int nargs,
TCGTemp **args)
if (is_32bit) {
TCGv_i64 temp = tcg_temp_new_i64();
- TCGv_i64 orig = temp_tcgv_i64(args[i]);
+ TCGv_i32 orig = temp_tcgv_i32(args[i]);
if (is_signed) {
- tcg_gen_ext32s_i64(temp, orig);
+ tcg_gen_ext_i32_i64(temp, orig);
} else {
- tcg_gen_ext32u_i64(temp, orig);
+ tcg_gen_extu_i32_i64(temp, orig);
}
args[i] = tcgv_i64_temp(temp);
}
--
2.25.1
- [PATCH] tcg: Extend call args using the correct opcodes,
Richard Henderson <=