qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tcg: Extend call args using the correct opcodes


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] tcg: Extend call args using the correct opcodes
Date: Thu, 28 Oct 2021 20:59:51 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0

On 10/28/21 20:44, Richard Henderson wrote:
> Pretending that the source is i64 when it is in fact i32 is
> incorrect; we have type-changing opcodes that must be used.
> This bug trips up the subsequent change to the optimizer.
> 
> Fixes: 4f2331e5b67a
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> 
> This fixes a problem found in s390x host testing, and should
> be considered patch 41.5/51 in
> 
>   [PATCH v4 00/51] tcg: optimize redundant sign extensions
> 
> just before 
> 
>   tcg/optimize: Stop forcing z_mask to "garbage" for 32-bit values
> 
> 
> r~
> 
> ---
>  tcg/tcg.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]