qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/4] softmmu: fix watchpoint processing in icount mode


From: Richard Henderson
Subject: Re: [PATCH 1/4] softmmu: fix watchpoint processing in icount mode
Date: Thu, 28 Oct 2021 12:09:50 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 10/28/21 4:48 AM, Pavel Dovgalyuk wrote:
Watchpoint processing code restores vCPU state twice:
in tb_check_watchpoint and in cpu_loop_exit_restore/cpu_restore_state.
Normally it does not affect anything, but in icount mode instruction
counter is incremented twice and becomes incorrect.
This patch eliminates unneeded CPU state restore.

Signed-off-by: Pavel Dovgalyuk<Pavel.Dovgalyuk@ispras.ru>
Reviewed-by: David Hildenbrand<david@redhat.com>
---
  softmmu/physmem.c |    6 ++----
  1 file changed, 2 insertions(+), 4 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]