Re: [PATCH v6 00/30] More SH4 clean ups (including code style series)

[Philippe Mathieu-Daudé]

On 10/29/21 23:02, BALATON Zoltan wrote:
> This now includes the previous code style clean up series so
> everything is in the series now. This got big enough for now so I'll
> wait until these are merged (hopefully before the freeze) before going
> on so I don't have to carry them in my tree. Only plan to submit
> another version if needed from review otherwise that's it for now,
> hopefully this is the last version.
> 
> v6: Found some lines with wrong indentation missed in code style clean
> up and one line missed removing sh_intc_source from header so I'm
> posting the whole series with these two small fixes, otherwise same as
> v5 but rebased on fixed code style series which is now also included.

> BALATON Zoltan (30):
>   hw/sh4: Coding style: Remove tabs
>   hw/sh4: Coding style: Fix multi-line comments
>   hw/sh4: Coding style: White space fixes
>   hw/sh4: Coding style: Add missing braces
>   hw/sh4: Coding style: Remove unnecessary casts
>   hw/sh4: Fix typos in a comment
>   hw/sh4: Change debug printfs to traces
>   hw/sh4/r2d: Use error_report instead of fprintf to stderr
>   hw/char/sh_serial: Do not abort on invalid access
>   hw/char/sh_serial: Rename type sh_serial_state to SHSerialState
>   hw/char/sh_serial: Embed QEMUTimer in state struct
>   hw/char/sh_serial: Split off sh_serial_reset() from sh_serial_init()
>   hw/char/sh_serial: QOM-ify
>   hw/char/sh_serial: Add device id to trace output
>   hw/intc/sh_intc: Use existing macro instead of local one
>   hw/intc/sh_intc: Turn some defines into an enum
>   hw/intc/sh_intc: Rename iomem region
>   hw/intc/sh_intc: Drop another useless macro
>   hw/intc/sh_intc: Move sh_intc_register() closer to its only user
>   hw/intc/sh_intc: Remove excessive parenthesis
>   hw/intc/sh_intc: Use array index instead of pointer arithmetics
>   hw/intc/sh_intc: Inline and drop sh_intc_source() function
>   hw/intc/sh_intc: Replace abort() with g_assert_not_reached()
>   hw/intc/sh_intc: Avoid using continue in loops
>   hw/intc/sh_intc: Simplify allocating sources array
>   hw/intc/sh_intc: Remove unneeded local variable initialisers
>   hw/timer/sh_timer: Rename sh_timer_state to SHTimerState
>   hw/timer/sh_timer: Do not wrap lines that are not too long
>   hw/timer/sh_timer: Fix timer memory region size
>   hw/timer/sh_timer: Remove use of hw_error

Hmm there is something odd with your mailer, your patches are
not sent in order, making it hard for tools to collect them.