Re: [PATCH v6 00/30] More SH4 clean ups (including code style series)

[BALATON Zoltan]

Hello,

On Sat, 30 Oct 2021, Philippe Mathieu-Daudé wrote:
> On 10/29/21 23:02, BALATON Zoltan wrote:
>
> > BALATON Zoltan (30):
> >   hw/sh4: Coding style: Remove tabs
> >   hw/sh4: Coding style: Fix multi-line comments
> >   hw/sh4: Coding style: White space fixes
> >   hw/sh4: Coding style: Add missing braces
> >   hw/sh4: Coding style: Remove unnecessary casts
> >   hw/sh4: Fix typos in a comment
> >   hw/sh4: Change debug printfs to traces
> >   hw/sh4/r2d: Use error_report instead of fprintf to stderr
> >   hw/char/sh_serial: Do not abort on invalid access
> >   hw/char/sh_serial: Rename type sh_serial_state to SHSerialState
> >   hw/char/sh_serial: Embed QEMUTimer in state struct
> >   hw/char/sh_serial: Split off sh_serial_reset() from sh_serial_init()
> >   hw/char/sh_serial: QOM-ify
> >   hw/char/sh_serial: Add device id to trace output
> >   hw/intc/sh_intc: Use existing macro instead of local one
> >   hw/intc/sh_intc: Turn some defines into an enum
> >   hw/intc/sh_intc: Rename iomem region
> >   hw/intc/sh_intc: Drop another useless macro
> >   hw/intc/sh_intc: Move sh_intc_register() closer to its only user
> >   hw/intc/sh_intc: Remove excessive parenthesis
> >   hw/intc/sh_intc: Use array index instead of pointer arithmetics
> >   hw/intc/sh_intc: Inline and drop sh_intc_source() function
> >   hw/intc/sh_intc: Replace abort() with g_assert_not_reached()
> >   hw/intc/sh_intc: Avoid using continue in loops
> >   hw/intc/sh_intc: Simplify allocating sources array
> >   hw/intc/sh_intc: Remove unneeded local variable initialisers
> >   hw/timer/sh_timer: Rename sh_timer_state to SHTimerState
> >   hw/timer/sh_timer: Do not wrap lines that are not too long
> >   hw/timer/sh_timer: Fix timer memory region size
> >   hw/timer/sh_timer: Remove use of hw_error
>
> Thanks, series queued.

Thanks again for taking care of this.

> Since you are hacking the SH-4 machines, please have a look at
> Yoshinori work, possibly helping with reviewing once he respin
> these series, which are good material (and where we want to
> take our emulation) but are not yet ready for upstream:
>
> "Unified peripheral emulation for Renesas chips"
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg811384.html
>
> "Integrate renesas MCU/SoC timer module"
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg818332.html

I'll try to do what I can but don't know SH too much just found it 
interesting so looked at it a bit. These series seem to touch timer and 
serial so I'll keep out of those now to not cause more rebasing for 
Yoshinori. (If you told me before then maybe I've left those but hopefully 
the clean up in this series does not cause big problems for rebasing the 
RX series and maybe help a little to see clearer what existing code does 
or where it should go.)

I plan to work on sh_intc next as that seems to need some improvements. 
Yoshinori, do you have any patches or plans for sh_intc? Maybe the 
interrupt controllers are different in RX and SH so these will be kept 
separate but asking to avoid doing work that's intended to be replaced 
anyway.

Regards,
BALATON Zoltan