[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 01/14] tests: fix test-cutils leaks
From: |
Thomas Huth |
Subject: |
[PULL 01/14] tests: fix test-cutils leaks |
Date: |
Tue, 5 Jul 2022 12:38:03 +0200 |
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Reported by ASAN.
Fixes commit cfb34489 ("cutils: add functions for IEC and SI prefixes").
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20220621083420.66365-1-marcandre.lureau@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/unit/test-cutils.c | 42 ++++++++++++++++++++++++++++++++--------
1 file changed, 34 insertions(+), 8 deletions(-)
diff --git a/tests/unit/test-cutils.c b/tests/unit/test-cutils.c
index f5b780f012..86caddcf64 100644
--- a/tests/unit/test-cutils.c
+++ b/tests/unit/test-cutils.c
@@ -2452,18 +2452,44 @@ static void test_qemu_strtosz_metric(void)
static void test_freq_to_str(void)
{
- g_assert_cmpstr(freq_to_str(999), ==, "999 Hz");
- g_assert_cmpstr(freq_to_str(1000), ==, "1 KHz");
- g_assert_cmpstr(freq_to_str(1010), ==, "1.01 KHz");
+ char *str;
+
+ str = freq_to_str(999);
+ g_assert_cmpstr(str, ==, "999 Hz");
+ g_free(str);
+
+ str = freq_to_str(1000);
+ g_assert_cmpstr(str, ==, "1 KHz");
+ g_free(str);
+
+ str = freq_to_str(1010);
+ g_assert_cmpstr(str, ==, "1.01 KHz");
+ g_free(str);
}
static void test_size_to_str(void)
{
- g_assert_cmpstr(size_to_str(0), ==, "0 B");
- g_assert_cmpstr(size_to_str(1), ==, "1 B");
- g_assert_cmpstr(size_to_str(1016), ==, "0.992 KiB");
- g_assert_cmpstr(size_to_str(1024), ==, "1 KiB");
- g_assert_cmpstr(size_to_str(512ull << 20), ==, "512 MiB");
+ char *str;
+
+ str = size_to_str(0);
+ g_assert_cmpstr(str, ==, "0 B");
+ g_free(str);
+
+ str = size_to_str(1);
+ g_assert_cmpstr(str, ==, "1 B");
+ g_free(str);
+
+ str = size_to_str(1016);
+ g_assert_cmpstr(str, ==, "0.992 KiB");
+ g_free(str);
+
+ str = size_to_str(1024);
+ g_assert_cmpstr(str, ==, "1 KiB");
+ g_free(str);
+
+ str = size_to_str(512ull << 20);
+ g_assert_cmpstr(str, ==, "512 MiB");
+ g_free(str);
}
static void test_iec_binary_prefix(void)
--
2.31.1
- [PULL 00/14] Testing and misc patches, Thomas Huth, 2022/07/05
- [PULL 02/14] tests/fp: Do not build softfloat3 tests if TCG is disabled, Thomas Huth, 2022/07/05
- [PULL 04/14] gitlab: tweak comments in edk2/opensbi jobs, Thomas Huth, 2022/07/05
- [PULL 01/14] tests: fix test-cutils leaks,
Thomas Huth <=
- [PULL 05/14] gitlab: honour QEMU_CI variable in edk2/opensbi jobs, Thomas Huth, 2022/07/05
- [PULL 07/14] tests: wait max 120 seconds for migration test status changes, Thomas Huth, 2022/07/05
- [PULL 03/14] gitlab: normalize indentation in edk2/opensbi rules, Thomas Huth, 2022/07/05
- [PULL 08/14] tests: wait for migration completion before looking for STOP event, Thomas Huth, 2022/07/05
- [PULL 10/14] tests: use consistent bandwidth/downtime limits in migration tests, Thomas Huth, 2022/07/05
- [PULL 06/14] gitlab-ci: Extend timeout for ubuntu-20.04-s390x-all to 75m, Thomas Huth, 2022/07/05
- [PULL 09/14] tests: increase migration test converge downtime to 30 seconds, Thomas Huth, 2022/07/05
- [PULL 12/14] po: add ukrainian translation, Thomas Huth, 2022/07/05
- [PULL 14/14] include/qemu/host-utils: Remove unused code in the *_overflow wrappers, Thomas Huth, 2022/07/05
- [PULL 13/14] meson.build: Require a recent version of libpng, Thomas Huth, 2022/07/05