Re: [PULL 00/54] virtio,pc,pci: fixes,cleanups,features

[Igor Mammedov]

On Thu, 14 Jul 2022 10:16:34 +0100
Peter Maydell <peter.maydell@linaro.org> wrote:

> On Fri, 10 Jun 2022 at 08:57, Michael S. Tsirkin <mst@redhat.com> wrote:
> > ----------------------------------------------------------------
> > virtio,pc,pci: fixes,cleanups,features
> >
> > more CXL patches
> > VIOT
> > Igor's huge AML rework
> > fixes, cleanups all over the place  
> 
> Hi. On my macos machine (an x86 one), 'make check' output for
> the bios-tables-test for both i386 and x86-64 guests now includes
> a warning message:
> 
> qemu-system-i386: -device isa-applesmc: warning: Using AppleSMC with invalid 
> key
> 
> I have not bisected but I rather suspect that this is the result of
> the applesmc test changes in this pullreq.

Like warning says, test case doesn't have SMC key after which
QEMU uses some made up default.

It can't suppressed with 'qtest_enabled()' since QEMU in test
doesn't use qtest as accelerator.

I'm more inclined to removing warning.

> 
> >       tests: acpi: add applesmc testcase  
> 
> 
>  45/582 qemu:qtest+qtest-i386 / qtest-i386/bios-tables-test
>   OK             108.07s   47 subtests passed
> ――――――――――――――――――――――――――――――――――――― ✀  ―――――――――――――――――――――――――――――――――――――
> stderr:
> 
> Looking for expected file 'tests/data/acpi/pc/FACP'
> Using expected file 'tests/data/acpi/pc/FACP'
> Looking for expected file 'tests/data/acpi/pc/APIC'
> Using expected file 'tests/data/acpi/pc/APIC'
> Looking for expected file 'tests/data/acpi/pc/HPET'
> Using expected file 'tests/data/acpi/pc/HPET'
> Looking for expected file 'tests/data/acpi/pc/WAET'
> Using expected file 'tests/data/acpi/pc/WAET'
> Looking for expected file 'tests/data/acpi/pc/FACS'
> Using expected file 'tests/data/acpi/pc/FACS'
> Looking for expected file 'tests/data/acpi/pc/DSDT'
> Using expected file 'tests/data/acpi/pc/DSDT'
> 
> [snip]
> Looking for expected file 'tests/data/acpi/q35/FACS.acpierst'
> Looking for expected file 'tests/data/acpi/q35/FACS'
> Using expected file 'tests/data/acpi/q35/FACS'
> Looking for expected file 'tests/data/acpi/q35/DSDT.acpierst'
> Using expected file 'tests/data/acpi/q35/DSDT.acpierst'
> qemu-system-i386: -device isa-applesmc: warning: Using AppleSMC with invalid 
> key
> 
> Looking for expected file 'tests/data/acpi/q35/FACP.applesmc'
> Looking for expected file 'tests/data/acpi/q35/FACP'
> Using expected file 'tests/data/acpi/q35/FACP'
> [snip]
> 
> 
> Could somebody investigate why this happens and fix it, please?
> 
> thanks
> -- PMM
>