Re: [PULL 00/54] virtio,pc,pci: fixes,cleanups,features

[Michael S. Tsirkin]

On Thu, Jul 14, 2022 at 01:41:46PM +0200, Igor Mammedov wrote:
> On Thu, 14 Jul 2022 10:16:34 +0100
> Peter Maydell <peter.maydell@linaro.org> wrote:
> 
> > On Fri, 10 Jun 2022 at 08:57, Michael S. Tsirkin <mst@redhat.com> wrote:
> > > ----------------------------------------------------------------
> > > virtio,pc,pci: fixes,cleanups,features
> > >
> > > more CXL patches
> > > VIOT
> > > Igor's huge AML rework
> > > fixes, cleanups all over the place  
> > 
> > Hi. On my macos machine (an x86 one), 'make check' output for
> > the bios-tables-test for both i386 and x86-64 guests now includes
> > a warning message:
> > 
> > qemu-system-i386: -device isa-applesmc: warning: Using AppleSMC with 
> > invalid key
> > 
> > I have not bisected but I rather suspect that this is the result of
> > the applesmc test changes in this pullreq.
> 
> Like warning says, test case doesn't have SMC key after which
> QEMU uses some made up default.
> 
> It can't suppressed with 'qtest_enabled()' since QEMU in test
> doesn't use qtest as accelerator.
> 
> I'm more inclined to removing warning.


yes:

    if (!s->osk || (strlen(s->osk) != 64)) {
        warn_report("Using AppleSMC with invalid key");
        s->osk = default_osk;
    }

I would say the incorrect length is right in producing the
warning, but the !s->osk case shouldn't warn.

Alex what do you think?


-- 
MST