Re: [PATCH 11/11] hw/arm: Add R52 machine

[Peter Maydell]

On Thu, 14 Jul 2022 at 15:54, Tobias Roehmel <quic_trohmel@quicinc.com> wrote:
>
> From: Tobias Röhmel <quic_trohmel@quicinc.com>
>
> Signed-off-by: Tobias Röhmel <quic_trohmel@quicinc.com>
> ---
>  configs/devices/arm-softmmu/default.mak |   1 +
>  hw/arm/Kconfig                          |   5 +
>  hw/arm/meson.build                      |   1 +
>  hw/arm/r52_machine.c                    | 133 +++++++++++++++
>  hw/arm/r52_virt.c                       | 217 ++++++++++++++++++++++++
>  include/hw/arm/r52_virt.h               |  61 +++++++

This needs justification about whether it's the right thing to do.
What's the purpose of the new machine? Would it be better as
part of the existing "virt" board? Is there a real physical
Cortex-R52 based machine that it would make more sense to model?
If we do need a new virtual R-profile board, should it really
be R52-specific?

I am generally not a fan of creating new entirely-QEMU-specific
machines if we can avoid it.

thanks
-- PMM