[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: migration-test: Allow test to run without uffd
From: |
Peter Xu |
Subject: |
Re: [PATCH] tests: migration-test: Allow test to run without uffd |
Date: |
Mon, 18 Jul 2022 15:14:37 -0400 |
Hi, Thomas,
On Mon, Jul 18, 2022 at 08:23:26PM +0200, Thomas Huth wrote:
> On 07/07/2022 20.46, Peter Xu wrote:
> > We used to stop running all tests if uffd is not detected. However
> > logically that's only needed for postcopy not the rest of tests.
> >
> > Keep running the rest when still possible.
> >
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> > ---
> > tests/qtest/migration-test.c | 11 +++++------
> > 1 file changed, 5 insertions(+), 6 deletions(-)
>
> Did you test your patch in the gitlab-CI? I just added it to my testing-next
> branch and the the test is failing reproducibly on macOS here:
>
> https://gitlab.com/thuth/qemu/-/jobs/2736260861#L6275
> https://gitlab.com/thuth/qemu/-/jobs/2736623914#L6275
>
> (without your patch the whole test is skipped instead)
Thanks for reporting this.
Is it easy to figure out which test was failing on your side? I cannot
easily reproduce this here on a MacOS with M1.
Or any hint on how I could kick the same CI as you do would help too. I
remembered I used to kick the test after any push with .gitlab-ci.yml but
it seems it's not triggering for some reason here.
--
Peter Xu
- [PATCH] tests: migration-test: Allow test to run without uffd, Peter Xu, 2022/07/07
- Re: [PATCH] tests: migration-test: Allow test to run without uffd, Daniel P . Berrangé, 2022/07/08
- Re: [PATCH] tests: migration-test: Allow test to run without uffd, Thomas Huth, 2022/07/18
- Re: [PATCH] tests: migration-test: Allow test to run without uffd,
Peter Xu <=
- Re: [PATCH] tests: migration-test: Allow test to run without uffd, Daniel P . Berrangé, 2022/07/19
- Re: [PATCH] tests: migration-test: Allow test to run without uffd, Thomas Huth, 2022/07/19
- Re: [PATCH] tests: migration-test: Allow test to run without uffd, Daniel P . Berrangé, 2022/07/19
- Re: [PATCH] tests: migration-test: Allow test to run without uffd, Peter Xu, 2022/07/19
- Re: [PATCH] tests: migration-test: Allow test to run without uffd, Thomas Huth, 2022/07/20
- Re: [PATCH] tests: migration-test: Allow test to run without uffd, Peter Xu, 2022/07/20
- Re: [PATCH] tests: migration-test: Allow test to run without uffd, Thomas Huth, 2022/07/20
- Re: [PATCH] tests: migration-test: Allow test to run without uffd, Daniel P . Berrangé, 2022/07/20
- Re: [PATCH] tests: migration-test: Allow test to run without uffd, Peter Xu, 2022/07/21
- Re: [PATCH] tests: migration-test: Allow test to run without uffd, Thomas Huth, 2022/07/22