Re: [PATCH] tests: migration-test: Allow test to run without uffd

[Daniel P . Berrangé]

On Mon, Jul 18, 2022 at 03:14:37PM -0400, Peter Xu wrote:
> Hi, Thomas,
> 
> On Mon, Jul 18, 2022 at 08:23:26PM +0200, Thomas Huth wrote:
> > On 07/07/2022 20.46, Peter Xu wrote:
> > > We used to stop running all tests if uffd is not detected.  However
> > > logically that's only needed for postcopy not the rest of tests.
> > > 
> > > Keep running the rest when still possible.
> > > 
> > > Signed-off-by: Peter Xu <peterx@redhat.com>
> > > ---
> > >   tests/qtest/migration-test.c | 11 +++++------
> > >   1 file changed, 5 insertions(+), 6 deletions(-)
> > 
> > Did you test your patch in the gitlab-CI? I just added it to my testing-next
> > branch and the the test is failing reproducibly on macOS here:
> > 
> >  https://gitlab.com/thuth/qemu/-/jobs/2736260861#L6275
> >  https://gitlab.com/thuth/qemu/-/jobs/2736623914#L6275
> > 
> > (without your patch the whole test is skipped instead)
> 
> Thanks for reporting this.
> 
> Is it easy to figure out which test was failing on your side?  I cannot
> easily reproduce this here on a MacOS with M1.
> 
> Or any hint on how I could kick the same CI as you do would help too.  I
> remembered I used to kick the test after any push with .gitlab-ci.yml but
> it seems it's not triggering for some reason here.

It is now opt-in with gitlab,  'git push -o ci.variable=QEMU_CI=1' to
create the pipeline, then in the UI manually start the jobs you wish
to run. Or QEMU_CI=2 to auto-run everything.

Note for MacOS you'll need to configure Cirrus CI integration first
though, per .gitlab-ci.d/cirrus/README


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|