|
From: | Richard Henderson |
Subject: | Re: [PATCH v3 1/5] target/loongarch/cpu: Fix cpu_class_by_name function |
Date: | Tue, 19 Jul 2022 12:16:42 +0530 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 |
On 7/15/22 11:37, Xiaojuan Yang wrote:
In loongarch_cpu_class_by_name(char *cpu_model) function, the argument cpu_model already has the suffix '-loongarch-cpu', so we should remove the LOONGARCH_CPU_TYPE_NAME(cpu_model) macro. And add the assertion that 'cpu_model' resolves to a class of the appropriate type. Signed-off-by: Xiaojuan Yang <yangxiaojuan@loongson.cn> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
This patch causes tests to fail, e.g. TEST float_convd on loongarch64 qemu-loongarch64: unable to find CPU model 'la464'make[1]: *** [/home/rth/qemu/src/tests/tcg/multiarch/Makefile.target:29: run-float_convd] Error 1
What caused you assume that all cpu models are already suffixed? r~
[Prev in Thread] | Current Thread | [Next in Thread] |