[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 08/14] tests/vm: add 1GB extra memory per core
From: |
Thomas Huth |
Subject: |
[PULL 08/14] tests/vm: add 1GB extra memory per core |
Date: |
Tue, 19 Jul 2022 09:04:06 +0200 |
From: John Snow <jsnow@redhat.com>
If you try to run a 16 or 32 threaded test, you're going to run out of
memory very quickly with qom-test and a few others. Bump the memory
limit to try to scale with larger-core machines.
Granted, this means that a 16 core processor is going to ask for 16GB,
but you *probably* meet that requirement if you have such a machine.
512MB per core didn't seem to be enough to avoid ENOMEM and SIGABRTs in
the test cases in practice on a six core machine; so I bumped it up to
1GB which seemed to help.
Add this magic in early to the configuration process so that the
config file, if provided, can still override it.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Acked-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220708153503.18864-9-jsnow@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/vm/basevm.py | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index d7d0413df3..4fd9af10b7 100644
--- a/tests/vm/basevm.py
+++ b/tests/vm/basevm.py
@@ -99,6 +99,11 @@ def __init__(self, args, config=None):
self._source_path = args.source_path
# Allow input config to override defaults.
self._config = DEFAULT_CONFIG.copy()
+
+ # 1GB per core, minimum of 4. This is only a default.
+ mem = max(4, args.jobs)
+ self._config['memory'] = f"{mem}G"
+
if config != None:
self._config.update(config)
self.validate_ssh_keys()
--
2.31.1
- [PULL 06/14] gitlab-ci: Extend timeout for ubuntu-20.04-s390x-all to 75m, (continued)
- [PULL 06/14] gitlab-ci: Extend timeout for ubuntu-20.04-s390x-all to 75m, Thomas Huth, 2022/07/05
- [PULL 09/14] tests: increase migration test converge downtime to 30 seconds, Thomas Huth, 2022/07/05
- [PULL 12/14] po: add ukrainian translation, Thomas Huth, 2022/07/05
- [PULL 14/14] include/qemu/host-utils: Remove unused code in the *_overflow wrappers, Thomas Huth, 2022/07/05
- [PULL 13/14] meson.build: Require a recent version of libpng, Thomas Huth, 2022/07/05
- [PULL 11/14] disas: Remove libvixl disassembler, Thomas Huth, 2022/07/05
- Re: [PULL 00/14] Testing and misc patches, Richard Henderson, 2022/07/05
- [PULL 00/14] Testing and misc patches, Thomas Huth, 2022/07/19
- [PULL 01/14] qga: treat get-guest-fsinfo as "best effort", Thomas Huth, 2022/07/19
- [PULL 05/14] tests/vm: upgrade Ubuntu 18.04 VM to 20.04, Thomas Huth, 2022/07/19
- [PULL 08/14] tests/vm: add 1GB extra memory per core,
Thomas Huth <=
- [PULL 02/14] tests/vm: use 'cp' instead of 'ln' for temporary vm images, Thomas Huth, 2022/07/19
- [PULL 07/14] tests/vm: remove duplicate 'centos' VM test, Thomas Huth, 2022/07/19
- [PULL 09/14] tests/vm: Remove docker cross-compile test from CentOS VM, Thomas Huth, 2022/07/19
- [PULL 11/14] tests/unit: Replace g_memdup() by g_memdup2(), Thomas Huth, 2022/07/19
- [PULL 04/14] tests/vm: switch centos.aarch64 to CentOS 8 Stream, Thomas Huth, 2022/07/19
- [PULL 10/14] qtest/machine-none: Add LoongArch support, Thomas Huth, 2022/07/19
- [PULL 13/14] util: Fix broken build on Haiku, Thomas Huth, 2022/07/19
- [PULL 12/14] Replace 'whitelist' with 'allow', Thomas Huth, 2022/07/19
- [PULL 14/14] python/qemu/qmp/legacy: Replace 'returns-whitelist' with the correct type, Thomas Huth, 2022/07/19
- [PULL 03/14] tests/vm: switch CentOS 8 to CentOS 8 Stream, Thomas Huth, 2022/07/19