[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 02/14] tests/vm: use 'cp' instead of 'ln' for temporary vm images
From: |
Thomas Huth |
Subject: |
[PULL 02/14] tests/vm: use 'cp' instead of 'ln' for temporary vm images |
Date: |
Tue, 19 Jul 2022 09:04:00 +0200 |
From: John Snow <jsnow@redhat.com>
If the initial setup fails, you've permanently altered the state of the
downloaded image in an unknowable way. Use 'cp' like our other test
setup scripts do.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220708153503.18864-3-jsnow@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/vm/centos | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vm/centos b/tests/vm/centos
index 5c7bc1c1a9..be4f6ff2f1 100755
--- a/tests/vm/centos
+++ b/tests/vm/centos
@@ -34,7 +34,7 @@ class CentosVM(basevm.BaseVM):
def build_image(self, img):
cimg =
self._download_with_cache("https://cloud.centos.org/centos/8/x86_64/images/CentOS-8-GenericCloud-8.3.2011-20201204.2.x86_64.qcow2")
img_tmp = img + ".tmp"
- subprocess.check_call(["ln", "-f", cimg, img_tmp])
+ subprocess.check_call(['cp', '-f', cimg, img_tmp])
self.exec_qemu_img("resize", img_tmp, "50G")
self.boot(img_tmp, extra_args = ["-cdrom", self.gen_cloud_init_iso()])
self.wait_ssh()
--
2.31.1
- [PULL 09/14] tests: increase migration test converge downtime to 30 seconds, (continued)
- [PULL 09/14] tests: increase migration test converge downtime to 30 seconds, Thomas Huth, 2022/07/05
- [PULL 12/14] po: add ukrainian translation, Thomas Huth, 2022/07/05
- [PULL 14/14] include/qemu/host-utils: Remove unused code in the *_overflow wrappers, Thomas Huth, 2022/07/05
- [PULL 13/14] meson.build: Require a recent version of libpng, Thomas Huth, 2022/07/05
- [PULL 11/14] disas: Remove libvixl disassembler, Thomas Huth, 2022/07/05
- Re: [PULL 00/14] Testing and misc patches, Richard Henderson, 2022/07/05
- [PULL 00/14] Testing and misc patches, Thomas Huth, 2022/07/19
- [PULL 01/14] qga: treat get-guest-fsinfo as "best effort", Thomas Huth, 2022/07/19
- [PULL 05/14] tests/vm: upgrade Ubuntu 18.04 VM to 20.04, Thomas Huth, 2022/07/19
- [PULL 08/14] tests/vm: add 1GB extra memory per core, Thomas Huth, 2022/07/19
- [PULL 02/14] tests/vm: use 'cp' instead of 'ln' for temporary vm images,
Thomas Huth <=
- [PULL 07/14] tests/vm: remove duplicate 'centos' VM test, Thomas Huth, 2022/07/19
- [PULL 09/14] tests/vm: Remove docker cross-compile test from CentOS VM, Thomas Huth, 2022/07/19
- [PULL 11/14] tests/unit: Replace g_memdup() by g_memdup2(), Thomas Huth, 2022/07/19
- [PULL 04/14] tests/vm: switch centos.aarch64 to CentOS 8 Stream, Thomas Huth, 2022/07/19
- [PULL 10/14] qtest/machine-none: Add LoongArch support, Thomas Huth, 2022/07/19
- [PULL 13/14] util: Fix broken build on Haiku, Thomas Huth, 2022/07/19
- [PULL 12/14] Replace 'whitelist' with 'allow', Thomas Huth, 2022/07/19
- [PULL 14/14] python/qemu/qmp/legacy: Replace 'returns-whitelist' with the correct type, Thomas Huth, 2022/07/19
- [PULL 03/14] tests/vm: switch CentOS 8 to CentOS 8 Stream, Thomas Huth, 2022/07/19
- [PULL 06/14] tests/vm: remove ubuntu.i386 VM test, Thomas Huth, 2022/07/19