qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] tests: refresh to latest libvirt-ci module


From: Thomas Huth
Subject: Re: [PATCH 1/3] tests: refresh to latest libvirt-ci module
Date: Thu, 21 Jul 2022 10:01:28 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0

On 20/07/2022 18.51, Daniel P. Berrangé wrote:
Notable changes:

   - libvirt-ci source tree was re-arranged, so script we must
     run now lives in a bin/ sub-dir

Sentence hard to parse for non-native like me. Maybe better:
"... so the script that we must run lives now in a bin/ sub-dir" ?

   - opensuse 15.2 is replaced by opensuse 15.3

   - libslirp is temporarily dropped on opensuse as the
     libslirp-version.h is broken

      https://bugzilla.opensuse.org/show_bug.cgi?id=1201551

   - The incorrectly named python3-virtualenv module was
     changed to python3-venv

I can see that e.g. py39-virtualenv is dropped from the freebsd.vars files now ... but no py39-venv package is installed instead? Is python3-venv installed there by other means (dependencies)?

   - glibc-static was renamed to libc-static, to reflect
     fact that it isn't going to be glibc on all distros

   - The cmocka/json-c deps that were manually added to
     the centos dockerfile and now consistently added
     to all targets

s/and now/are now/ ?

Apart from the nits:
Acked-by: Thomas Huth <thuth@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]