Re: [PATCH 1/3] tests: refresh to latest libvirt-ci module

[Daniel P . Berrangé]

On Thu, Jul 21, 2022 at 10:01:28AM +0200, Thomas Huth wrote:
> On 20/07/2022 18.51, Daniel P. Berrangé wrote:
> > Notable changes:
> > 
> >    - libvirt-ci source tree was re-arranged, so script we must
> >      run now lives in a bin/ sub-dir
> 
> Sentence hard to parse for non-native like me. Maybe better:
> "... so the script that we must run lives now in a bin/ sub-dir" ?
> 
> >    - opensuse 15.2 is replaced by opensuse 15.3
> > 
> >    - libslirp is temporarily dropped on opensuse as the
> >      libslirp-version.h is broken
> > 
> >       https://bugzilla.opensuse.org/show_bug.cgi?id=1201551
> > 
> >    - The incorrectly named python3-virtualenv module was
> >      changed to python3-venv
> 
> I can see that e.g.  py39-virtualenv is dropped from the freebsd.vars files
> now ... but no py39-venv package is installed instead? Is python3-venv
> installed there by other means (dependencies)?

There's no such thing as 'python3-venv' in almost all OS this
is a built-in standard part of the python dist. This is the
root of the original confusion. I saw 'python3-venv' on Debian
and assumed that it was the same as 'pthon3-virtualenv' on
all other platforms. In fact Debian has just done a wierd
thing by requiring 'python3-venv' whole everyone else gives
it by default with python.

> 
> >    - glibc-static was renamed to libc-static, to reflect
> >      fact that it isn't going to be glibc on all distros
> > 
> >    - The cmocka/json-c deps that were manually added to
> >      the centos dockerfile and now consistently added
> >      to all targets
> 
> s/and now/are now/ ?
> 
> Apart from the nits:
> Acked-by: Thomas Huth <thuth@redhat.com>
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|