[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 01/21] include/hw/virtio: more comment for VIRTIO_F_BAD_FEATUR
From: |
Alex Bennée |
Subject: |
[PATCH v3 01/21] include/hw/virtio: more comment for VIRTIO_F_BAD_FEATURE |
Date: |
Tue, 26 Jul 2022 20:21:30 +0100 |
When debugging a new vhost user you may be surprised to see
VHOST_USER_F_PROTOCOL getting squashed in the maze of
backend_features, acked_features and guest_features. Expand the
description here to help the next poor soul trying to work through
this.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
v3
- s/vhost/vhost-user/
---
include/hw/virtio/virtio.h | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
index db1c0ddf6b..9bb2485415 100644
--- a/include/hw/virtio/virtio.h
+++ b/include/hw/virtio/virtio.h
@@ -24,7 +24,12 @@
#include "qom/object.h"
#include "hw/virtio/vhost.h"
-/* A guest should never accept this. It implies negotiation is broken. */
+/*
+ * A guest should never accept this. It implies negotiation is broken
+ * between the driver frontend and the device. This bit is re-used for
+ * vhost-user to advertise VHOST_USER_F_PROTOCOL_FEATURES between QEMU
+ * and a vhost-user backend.
+ */
#define VIRTIO_F_BAD_FEATURE 30
#define VIRTIO_LEGACY_FEATURES ((0x1ULL << VIRTIO_F_BAD_FEATURE) | \
--
2.30.2
- [PATCH v3 for 7.2 00/21] virtio-gpio and various virtio cleanups, Alex Bennée, 2022/07/26
- [PATCH v3 01/21] include/hw/virtio: more comment for VIRTIO_F_BAD_FEATURE,
Alex Bennée <=
- [PATCH v3 02/21] include/hw: document vhost_dev feature life-cycle, Alex Bennée, 2022/07/26
- [PATCH v3 03/21] hw/virtio: fix some coding style issues, Alex Bennée, 2022/07/26
- [PATCH v3 15/21] tests/qtest: use qos_printf instead of g_test_message, Alex Bennée, 2022/07/26
- [PATCH v3 06/21] hw/virtio: incorporate backend features in features, Alex Bennée, 2022/07/26
- [PATCH v3 20/21] tests/qtest: add a get_features op to vhost-user-test, Alex Bennée, 2022/07/26
- [PATCH v3 04/21] hw/virtio: log potentially buggy guest drivers, Alex Bennée, 2022/07/26